Linux CXL
 help / color / mirror / Atom feed
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
To: <imammedo@redhat.com>, <mst@redhat.com>,
	Markus Armbruster <armbru@redhat.com>, <qemu-devel@nongnu.org>,
	<ankita@nvidia.com>
Cc: <linuxarm@huawei.com>, <linux-cxl@vger.kernel.org>,
	<marcel.apfelbaum@gmail.com>, <philmd@linaro.org>,
	Richard Henderson <richard.henderson@linaro.org>,
	Dave Jiang <dave.jiang@intel.com>,
	Huang Ying <ying.huang@intel.com>,
	Paolo Bonzini <pbonzini@redhat.com>, <eduardo@habkost.net>,
	Michael Roth <michael.roth@amd.com>,
	Ani Sinha <anisinha@redhat.com>
Subject: [PATCH v6 11/15] hw/acpi: Make storage of node id uint32_t to reduce fragility
Date: Mon, 16 Sep 2024 18:42:37 +0100	[thread overview]
Message-ID: <20240916174237.1843213-1-Jonathan.Cameron@huawei.com> (raw)
In-Reply-To: <20240916171017.1841767-1-Jonathan.Cameron@huawei.com>

From review of generic port introduction.

The value is handled as a uint32_t so store it in that type.
The value cannot in reality exceed MAX_NODES which is currently
128 but if the types are matched there is no need to rely on that
restriction.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
v6: New patch bringing Generic Initiator handling inline with
    updated generic ports code following Igor's review.
    Kind of suggested-by Igor, indirectly...
---
 include/hw/acpi/aml-build.h | 2 +-
 hw/acpi/aml-build.c         | 2 +-
 hw/acpi/pci.c               | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h
index 47a4692a7d..4fd5da49e7 100644
--- a/include/hw/acpi/aml-build.h
+++ b/include/hw/acpi/aml-build.h
@@ -486,7 +486,7 @@ Aml *build_crs(PCIHostState *host, CrsRangeSet *range_set, uint32_t io_offset,
 void build_srat_memory(GArray *table_data, uint64_t base,
                        uint64_t len, int node, MemoryAffinityFlags flags);
 
-void build_srat_pci_generic_initiator(GArray *table_data, int node,
+void build_srat_pci_generic_initiator(GArray *table_data, uint32_t node,
                                       uint16_t segment, uint8_t bus,
                                       uint8_t devfn);
 
diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
index 4aa4debf44..91540df826 100644
--- a/hw/acpi/aml-build.c
+++ b/hw/acpi/aml-build.c
@@ -1973,7 +1973,7 @@ static void build_append_srat_acpi_device_handle(GArray *table_data,
  * 5.2.16.6 Generic Initiator Affinity Structure
  *    With PCI Device Handle.
  */
-void build_srat_pci_generic_initiator(GArray *table_data, int node,
+void build_srat_pci_generic_initiator(GArray *table_data, uint32_t node,
                                       uint16_t segment, uint8_t bus,
                                       uint8_t devfn)
 {
diff --git a/hw/acpi/pci.c b/hw/acpi/pci.c
index d7a0e91f01..a4835ce563 100644
--- a/hw/acpi/pci.c
+++ b/hw/acpi/pci.c
@@ -72,7 +72,7 @@ typedef struct AcpiGenericInitiator {
 
     /* public */
     char *pci_dev;
-    uint16_t node;
+    uint32_t node;
 } AcpiGenericInitiator;
 
 typedef struct AcpiGenericInitiatorClass {
-- 
2.43.0


  parent reply	other threads:[~2024-09-16 17:42 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-16 17:10 [PATCH v6 00/15] acpi: NUMA nodes for CXL HB as GP + complex NUMA test Jonathan Cameron
2024-09-16 17:10 ` [PATCH v6 01/15] hw/acpi: Fix ordering of BDF in Generic Initiator PCI Device Handle Jonathan Cameron
2024-11-06 12:17   ` Michael Tokarev
2024-09-16 17:10 ` [PATCH v6 02/15] hw/acpi/GI: Fix trivial parameter alignment issue Jonathan Cameron
2024-09-16 17:10 ` [PATCH v6 03/15] hw/acpi: Move AML building code for Generic Initiators to aml_build.c Jonathan Cameron
2024-09-16 17:10 ` [PATCH v6 04/15] hw/acpi: Rename build_all_acpi_generic_initiators() to build_acpi_generic_initiator() Jonathan Cameron
2024-09-16 17:10 ` [PATCH v6 05/15] hw/pci: Add a busnr property to pci_props and use for acpi/gi Jonathan Cameron
2024-09-16 17:10 ` [PATCH v6 06/15] acpi/pci: Move Generic Initiator object handling into acpi/pci.* Jonathan Cameron
2024-09-16 17:10 ` [PATCH v6 07/15] hw/pci-bridge: Add acpi_uid property to TYPE_PXB_BUS Jonathan Cameron
2024-09-16 17:10 ` [PATCH v6 08/15] hw/i386/acpi: Use TYPE_PXB_BUS property acpi_uid for DSDT Jonathan Cameron
2024-09-16 17:10 ` [PATCH v6 09/15] hw/pci-host/gpex-acpi: Use acpi_uid property Jonathan Cameron
2024-09-16 17:41 ` [PATCH v6 10/15] hw/acpi: Generic Port Affinity Structure support Jonathan Cameron
2024-11-06 18:13   ` Jonathan Cameron
2024-09-16 17:42 ` Jonathan Cameron [this message]
2024-09-16 17:43 ` [PATCH v6 12/15] hw/acpi: Generic Initiator - add missing object class property descriptions Jonathan Cameron
2024-09-16 17:44 ` [PATCH v6 13/15] bios-tables-test: Allow for new acpihmat-generic-x test data Jonathan Cameron
2024-09-16 17:44 ` [PATCH v6 14/15] bios-tables-test: Add complex SRAT / HMAT test for GI GP Jonathan Cameron
2024-11-04 16:00   ` Michael S. Tsirkin
2024-11-06 12:27     ` Jonathan Cameron
2024-11-07 11:48       ` Jonathan Cameron
2024-09-16 17:45 ` [PATCH v6 15/15] bios-tables-test: Add data for complex numa test (GI, GP etc) Jonathan Cameron
2024-10-29 10:25 ` [PATCH v6 00/15] acpi: NUMA nodes for CXL HB as GP + complex NUMA test Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240916174237.1843213-1-Jonathan.Cameron@huawei.com \
    --to=jonathan.cameron@huawei.com \
    --cc=anisinha@redhat.com \
    --cc=ankita@nvidia.com \
    --cc=armbru@redhat.com \
    --cc=dave.jiang@intel.com \
    --cc=eduardo@habkost.net \
    --cc=imammedo@redhat.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=michael.roth@amd.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox