From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Lukas Wunner <lukas@wunner.de>
Cc: Gregory Price <gourry@gourry.net>, <linux-pci@vger.kernel.org>,
<linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<dan.j.williams@intel.com>, <bhelgaas@google.com>,
<dave@stgolabs.net>, <dave.jiang@intel.com>,
<vishal.l.verma@intel.com>
Subject: Re: [PATCH] PCI/DOE: Poll DOE Busy bit for up to 1 second in pci_doe_send_req
Date: Thu, 10 Oct 2024 17:23:26 +0100 [thread overview]
Message-ID: <20241010172326.00004d1a@Huawei.com> (raw)
In-Reply-To: <ZweukOWeqFy8vd4W@wunner.de>
On Thu, 10 Oct 2024 12:38:08 +0200
Lukas Wunner <lukas@wunner.de> wrote:
> On Fri, Oct 04, 2024 at 12:28:28PM -0400, Gregory Price wrote:
> > Polling on the PCI DOE Busy Bit for (at max) one PCI DOE timeout
> > interval (1 second), resolves this issues cleanly.
>
> Nit: s/issues/issue/
>
> > Subsqeuent code in doe_statemachine_work and abort paths also wait
>
> Nit: s/Subsqeuent/Subsequent/
>
> > --- a/drivers/pci/doe.c
> > +++ b/drivers/pci/doe.c
> > @@ -149,14 +149,26 @@ static int pci_doe_send_req(struct pci_doe_mb *doe_mb,
> > size_t length, remainder;
> > u32 val;
> > int i;
> > + unsigned long timeout_jiffies;
>
> Nit: Reverse Christmas tree.
>
> With that addressed,
> Reviewed-by: Lukas Wunner <lukas@wunner.de>
>
Looks good to me with Lukas' nits tidied up.
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
next prev parent reply other threads:[~2024-10-10 16:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-04 16:28 [PATCH] PCI/DOE: Poll DOE Busy bit for up to 1 second in pci_doe_send_req Gregory Price
2024-10-10 10:38 ` Lukas Wunner
2024-10-10 16:23 ` Jonathan Cameron [this message]
2024-10-10 22:16 ` Bjorn Helgaas
2024-10-11 13:59 ` Gregory Price
2024-10-13 11:08 ` Lukas Wunner
2024-10-13 15:58 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241010172326.00004d1a@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=bhelgaas@google.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=gourry@gourry.net \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox