From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
To: <mst@redhat.com>, <qemu-devel@nongnu.org>
Cc: Dmitry Frolov <frolov@swemel.ru>,
Ajay Joshi <ajay.opensrc@micron.com>,
Yao Xingtao <yaoxt.fnst@fujitsu.com>, Fan Ni <fan.ni@samsung.com>,
Shiju Jose <shiju.jose@huawei.com>, <linux-cxl@vger.kernel.org>,
<linuxarm@huawei.com>
Subject: [PATCH qemu 2/7] hw/cxl: Fix background completion percentage calculation
Date: Mon, 14 Oct 2024 13:18:57 +0100 [thread overview]
Message-ID: <20241014121902.2146424-3-Jonathan.Cameron@huawei.com> (raw)
In-Reply-To: <20241014121902.2146424-1-Jonathan.Cameron@huawei.com>
From: Ajay Joshi <ajayjoshi@micron.com>
The current completion percentage calculation does not account for the
relative time since the start of the background activity, this leads to
showing incorrect start percentage vs what has actually been completed.
This patch calculates the percentage based on the actual elapsed time since
the start of the operation.
Fixes: 221d2cfbdb53 ("hw/cxl/mbox: Add support for background operations")
Signed-off-by: Ajay Joshi <ajay.opensrc@micron.com>
Reviewed-by: Davidlohr Bueso <dave@stgolabs.net>
Link: https://lore.kernel.org/r/20240729102338.22337-1-ajay.opensrc@micron.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
hw/cxl/cxl-mailbox-utils.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/cxl/cxl-mailbox-utils.c b/hw/cxl/cxl-mailbox-utils.c
index 9f794e4655..3a93966e77 100644
--- a/hw/cxl/cxl-mailbox-utils.c
+++ b/hw/cxl/cxl-mailbox-utils.c
@@ -2879,7 +2879,8 @@ static void bg_timercb(void *opaque)
}
} else {
/* estimate only */
- cci->bg.complete_pct = 100 * now / total_time;
+ cci->bg.complete_pct =
+ 100 * (now - cci->bg.starttime) / cci->bg.runtime;
timer_mod(cci->bg.timer, now + CXL_MBOX_BG_UPDATE_FREQ);
}
--
2.43.0
next prev parent reply other threads:[~2024-10-14 12:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-14 12:18 [PATCH 0/7] hw/cxl: Round up of fixes Jonathan Cameron
2024-10-14 12:18 ` [PATCH qemu 1/7] hw/cxl: Fix uint32 overflow cxl-mailbox-utils.c Jonathan Cameron
2024-10-14 12:18 ` Jonathan Cameron [this message]
2024-10-14 12:18 ` [PATCH qemu 3/7] mem/cxl_type3: Fix overlapping region validation error Jonathan Cameron
2024-10-14 12:18 ` [PATCH qemu 4/7] hw/mem/cxl_type3: Fix More flag setting for dynamic capacity event records Jonathan Cameron
2024-10-14 12:19 ` [PATCH qemu 5/7] hw/cxl/cxl-mailbox-utils: Fix for device DDR5 ECS control feature tables Jonathan Cameron
2024-10-14 12:19 ` [PATCH qemu 6/7] hw/cxl: Fix indent of structure member Jonathan Cameron
2024-10-14 12:19 ` [PATCH qemu 7/7] hw/pci-bridge: Make pxb_dev_realize_common() return if it succeeded Jonathan Cameron
2024-10-14 12:54 ` [PATCH 0/7] hw/cxl: Round up of fixes Jonathan Cameron
2024-11-06 19:57 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241014121902.2146424-3-Jonathan.Cameron@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=ajay.opensrc@micron.com \
--cc=fan.ni@samsung.com \
--cc=frolov@swemel.ru \
--cc=linux-cxl@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=shiju.jose@huawei.com \
--cc=yaoxt.fnst@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox