Linux CXL
 help / color / mirror / Atom feed
From: Ira Weiny <ira.weiny@intel.com>
To: Dave Jiang <dave.jiang@intel.com>, Fan Ni <fan.ni@samsung.com>,
	 Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	 Navneet Singh <navneet.singh@intel.com>,
	Jonathan Corbet <corbet@lwn.net>,
	 Andrew Morton <akpm@linux-foundation.org>
Cc: Dan Williams <dan.j.williams@intel.com>,
	 Davidlohr Bueso <dave@stgolabs.net>,
	 Alison Schofield <alison.schofield@intel.com>,
	 Vishal Verma <vishal.l.verma@intel.com>,
	Ira Weiny <ira.weiny@intel.com>,
	 linux-cxl@vger.kernel.org, linux-doc@vger.kernel.org,
	 nvdimm@lists.linux.dev, linux-kernel@vger.kernel.org,
	 Li Ming <ming4.li@intel.com>
Subject: [PATCH v7 04/27] cxl/pci: Delay event buffer allocation
Date: Thu, 07 Nov 2024 14:58:22 -0600	[thread overview]
Message-ID: <20241107-dcd-type2-upstream-v7-4-56a84e66bc36@intel.com> (raw)
In-Reply-To: <20241107-dcd-type2-upstream-v7-0-56a84e66bc36@intel.com>

The event buffer does not need to be allocated if something has failed in
setting up event irq's.

In prep for adjusting event configuration for DCD events move the buffer
allocation to the end of the event configuration.

Reviewed-by: Davidlohr Bueso <dave@stgolabs.net>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Fan Ni <fan.ni@samsung.com>
Reviewed-by: Li Ming <ming4.li@intel.com>
Link: https://lore.kernel.org/all/663922b475e50_d54d72945b@dwillia2-xfh.jf.intel.com.notmuch/ [1]
Suggested-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Ira Weiny <ira.weiny@intel.com>
---
 drivers/cxl/pci.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/cxl/pci.c b/drivers/cxl/pci.c
index 188412d45e0d266b19f7401a1cdc51ed6fb0ea0a..295779c433b2a2e377995b53a70ff2a3158b0a8e 100644
--- a/drivers/cxl/pci.c
+++ b/drivers/cxl/pci.c
@@ -764,10 +764,6 @@ static int cxl_event_config(struct pci_host_bridge *host_bridge,
 		return 0;
 	}
 
-	rc = cxl_mem_alloc_event_buf(mds);
-	if (rc)
-		return rc;
-
 	rc = cxl_event_get_int_policy(mds, &policy);
 	if (rc)
 		return rc;
@@ -781,6 +777,10 @@ static int cxl_event_config(struct pci_host_bridge *host_bridge,
 		return -EBUSY;
 	}
 
+	rc = cxl_mem_alloc_event_buf(mds);
+	if (rc)
+		return rc;
+
 	rc = cxl_event_irqsetup(mds);
 	if (rc)
 		return rc;

-- 
2.47.0


  parent reply	other threads:[~2024-11-07 20:58 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-07 20:58 [PATCH v7 00/27] DCD: Add support for Dynamic Capacity Devices (DCD) Ira Weiny
2024-11-07 20:58 ` [PATCH v7 01/27] range: Add range_overlaps() Ira Weiny
2024-11-07 20:58 ` [PATCH v7 02/27] ACPI/CDAT: Add CDAT/DSMAS shared and read only flag values Ira Weiny
2024-11-07 20:58 ` [PATCH v7 03/27] dax: Document struct dev_dax_range Ira Weiny
2024-11-07 20:58 ` Ira Weiny [this message]
2024-11-07 20:58 ` [PATCH v7 05/27] cxl/hdm: Use guard() in cxl_dpa_set_mode() Ira Weiny
2024-11-07 20:58 ` [PATCH v7 06/27] cxl/region: Refactor common create region code Ira Weiny
2024-11-07 20:58 ` [PATCH v7 07/27] cxl/mbox: Flag support for Dynamic Capacity Devices (DCD) ira.weiny
2024-11-07 20:58 ` [PATCH v7 08/27] cxl/mem: Read dynamic capacity configuration from the device ira.weiny
2024-11-07 20:58 ` [PATCH v7 09/27] cxl/core: Separate region mode from decoder mode ira.weiny
2024-11-07 20:58 ` [PATCH v7 10/27] cxl/region: Add dynamic capacity decoder and region modes ira.weiny
2024-11-07 20:58 ` [PATCH v7 11/27] cxl/hdm: Add dynamic capacity size support to endpoint decoders ira.weiny
2024-11-07 20:58 ` [PATCH v7 12/27] cxl/cdat: Gather DSMAS data for DCD regions Ira Weiny
2024-11-07 20:58 ` [PATCH v7 13/27] cxl/mem: Expose DCD partition capabilities in sysfs ira.weiny
2024-11-07 20:58 ` [PATCH v7 14/27] cxl/port: Add endpoint decoder DC mode support to sysfs ira.weiny
2024-11-07 20:58 ` [PATCH v7 15/27] cxl/region: Add sparse DAX region support ira.weiny
2024-11-07 20:58 ` [PATCH v7 16/27] cxl/events: Split event msgnum configuration from irq setup Ira Weiny
2024-11-07 20:58 ` [PATCH v7 17/27] cxl/pci: Factor out interrupt policy check Ira Weiny
2024-11-07 20:58 ` [PATCH v7 18/27] cxl/mem: Configure dynamic capacity interrupts ira.weiny
2024-11-07 20:58 ` [PATCH v7 19/27] cxl/core: Return endpoint decoder information from region search Ira Weiny
2024-11-07 20:58 ` [PATCH v7 20/27] cxl/extent: Process DCD events and realize region extents ira.weiny
2024-11-07 20:58 ` [PATCH v7 21/27] cxl/region/extent: Expose region extent information in sysfs ira.weiny
2024-11-07 20:58 ` [PATCH v7 22/27] dax/bus: Factor out dev dax resize logic Ira Weiny
2024-11-07 20:58 ` [PATCH v7 23/27] dax/region: Create resources on sparse DAX regions ira.weiny
2024-11-07 20:58 ` [PATCH v7 24/27] cxl/region: Read existing extents on region creation ira.weiny
2024-11-07 20:58 ` [PATCH v7 25/27] cxl/mem: Trace Dynamic capacity Event Record ira.weiny
2024-11-07 20:58 ` [PATCH v7 26/27] tools/testing/cxl: Make event logs dynamic Ira Weiny
2024-11-07 20:58 ` [PATCH v7 27/27] tools/testing/cxl: Add DC Regions to mock mem data Ira Weiny
2024-11-08 17:27 ` [PATCH v7 00/27] DCD: Add support for Dynamic Capacity Devices (DCD) Dave Jiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241107-dcd-type2-upstream-v7-4-56a84e66bc36@intel.com \
    --to=ira.weiny@intel.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=alison.schofield@intel.com \
    --cc=corbet@lwn.net \
    --cc=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=dave@stgolabs.net \
    --cc=fan.ni@samsung.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming4.li@intel.com \
    --cc=navneet.singh@intel.com \
    --cc=nvdimm@lists.linux.dev \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox