From: Zijun Hu <zijun_hu@icloud.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Tejun Heo <tj@kernel.org>, Josef Bacik <josef@toxicpanda.com>,
Jens Axboe <axboe@kernel.dk>, Boris Burkov <boris@bur.io>,
Davidlohr Bueso <dave@stgolabs.net>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
Dave Jiang <dave.jiang@intel.com>,
Alison Schofield <alison.schofield@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
Dan Williams <dan.j.williams@intel.com>
Cc: Zijun Hu <zijun_hu@icloud.com>,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
linux-block@vger.kernel.org, linux-cxl@vger.kernel.org,
Zijun Hu <quic_zijuhu@quicinc.com>
Subject: [PATCH v4 5/8] driver core: Correct parameter check for API device_for_each_child_reverse_from()
Date: Wed, 18 Dec 2024 08:01:35 +0800 [thread overview]
Message-ID: <20241218-class_fix-v4-5-3c40f098356b@quicinc.com> (raw)
In-Reply-To: <20241218-class_fix-v4-0-3c40f098356b@quicinc.com>
From: Zijun Hu <quic_zijuhu@quicinc.com>
device_for_each_child_reverse_from() checks (!parent->p) for its
parameter @parent, and that is not consistent with other APIs of
its cluster as shown below:
device_for_each_child_reverse_from() // check (!parent->p)
device_for_each_child_reverse() // check (!parent || !parent->p)
device_for_each_child() // same above
device_find_child() // same above
Correct the API's parameter @parent check by (!parent || !parent->p).
Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
---
drivers/base/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/base/core.c b/drivers/base/core.c
index 69bb6bf4bd12395226ee3c99e2f63d15c7e342a5..34fb13f914b3db47e6a047fdabf3c9b18ecc08cc 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -4050,7 +4050,7 @@ int device_for_each_child_reverse_from(struct device *parent,
struct device *child;
int error = 0;
- if (!parent->p)
+ if (!parent || !parent->p)
return 0;
klist_iter_init_node(&parent->p->klist_children, &i,
--
2.34.1
next prev parent reply other threads:[~2024-12-18 0:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-18 0:01 [PATCH v4 0/8] driver core: class: Fix bug and code improvements for class APIs Zijun Hu
2024-12-18 0:01 ` [PATCH v4 1/8] driver core: class: Fix wild pointer dereferences in API class_dev_iter_next() Zijun Hu
2024-12-23 20:09 ` Jonathan Cameron
2024-12-18 0:01 ` [PATCH v4 2/8] blk-cgroup: Fix class @block_class's subsystem refcount leakage Zijun Hu
2024-12-18 16:39 ` Tejun Heo
2024-12-18 0:01 ` [PATCH v4 3/8] driver core: Move true expression out of if condition in 3 device finding APIs Zijun Hu
2024-12-18 0:01 ` [PATCH v4 4/8] driver core: Rename declaration parameter name for API device_find_child() cluster Zijun Hu
2024-12-18 0:01 ` Zijun Hu [this message]
2024-12-18 0:01 ` [PATCH v4 6/8] driver core: Correct API device_for_each_child_reverse_from() prototype Zijun Hu
2024-12-18 0:01 ` [PATCH v4 7/8] driver core: Introduce device_iter_t for device iterating APIs Zijun Hu
2024-12-18 0:01 ` [PATCH v4 8/8] driver core: Move 2 one line device finding APIs to header Zijun Hu
2024-12-23 20:11 ` Jonathan Cameron
2024-12-24 12:33 ` Zijun Hu
2024-12-24 16:21 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241218-class_fix-v4-5-3c40f098356b@quicinc.com \
--to=zijun_hu@icloud.com \
--cc=alison.schofield@intel.com \
--cc=axboe@kernel.dk \
--cc=boris@bur.io \
--cc=cgroups@vger.kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=gregkh@linuxfoundation.org \
--cc=ira.weiny@intel.com \
--cc=jonathan.cameron@huawei.com \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_zijuhu@quicinc.com \
--cc=rafael@kernel.org \
--cc=tj@kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox