Linux CXL
 help / color / mirror / Atom feed
From: Robert Richter <rrichter@amd.com>
To: Alison Schofield <alison.schofield@intel.com>,
	Vishal Verma <vishal.l.verma@intel.com>,
	Ira Weiny <ira.weiny@intel.com>,
	Dan Williams <dan.j.williams@intel.com>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	Dave Jiang <dave.jiang@intel.com>,
	Davidlohr Bueso <dave@stgolabs.net>
Cc: <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Gregory Price <gourry@gourry.net>,
	"Fabio M. De Francesco" <fabio.m.de.francesco@linux.intel.com>,
	Terry Bowman <terry.bowman@amd.com>,
	Robert Richter <rrichter@amd.com>
Subject: [PATCH v2 16/18] cxl/region: Show message on broken target list
Date: Fri, 7 Feb 2025 16:37:51 +0100	[thread overview]
Message-ID: <20250207153753.418849-17-rrichter@amd.com> (raw)
In-Reply-To: <20250207153753.418849-1-rrichter@amd.com>

Broken target lists are hard to discover as the driver fails at a
later initialization stage. Add an error message for this.

Signed-off-by: Robert Richter <rrichter@amd.com>
Reviewed-by: Gregory Price <gourry@gourry.net>
---
 drivers/cxl/core/region.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c
index 606f5652114b..3b578ca167e5 100644
--- a/drivers/cxl/core/region.c
+++ b/drivers/cxl/core/region.c
@@ -1790,6 +1790,13 @@ static int find_pos_and_ways(struct cxl_port *port, struct range *range,
 	}
 	put_device(dev);
 
+	if (rc)
+		dev_err(port->uport_dev,
+			"failed to find %s:%s in target list of %s\n",
+			dev_name(&port->dev),
+			dev_name(port->parent_dport->dport_dev),
+			dev_name(&cxlsd->cxld.dev));
+
 	return rc;
 }
 
-- 
2.39.5


  parent reply	other threads:[~2025-02-07 15:39 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-07 15:37 [PATCH v2 00/18] cxl: Address translation support, part 1: Cleanups and refactoring Robert Richter
2025-02-07 15:37 ` [PATCH v2 01/18] cxl: Remove else after return Robert Richter
2025-02-07 18:11   ` Jonathan Cameron
2025-02-07 23:56   ` Davidlohr Bueso
2025-02-07 15:37 ` [PATCH v2 02/18] cxl/pci: Moving code in cxl_hdm_decode_init() Robert Richter
2025-02-07 16:02   ` Gregory Price
2025-02-07 23:57   ` Davidlohr Bueso
2025-02-07 15:37 ` [PATCH v2 03/18] cxl/pci: cxl_hdm_decode_init: Move comment Robert Richter
2025-02-07 16:02   ` Gregory Price
2025-02-07 21:36     ` Jim Kao
2025-02-07 22:19       ` Gregory Price
2025-02-10 11:07         ` Robert Richter
2025-02-07 15:37 ` [PATCH v2 04/18] cxl/pci: Add comments to cxl_hdm_decode_init() Robert Richter
2025-02-07 15:37 ` [PATCH v2 05/18] cxl: Introduce parent_port_of() helper Robert Richter
2025-02-07 23:08   ` Alison Schofield
2025-02-10 11:38     ` Robert Richter
2025-02-07 15:37 ` [PATCH v2 06/18] cxl/region: Rename function to cxl_find_decoder_early() Robert Richter
2025-02-07 15:37 ` [PATCH v2 07/18] cxl/region: Avoid duplicate call of cxl_find_decoder_early() Robert Richter
2025-02-07 15:37 ` [PATCH v2 08/18] cxl/region: Move find_cxl_root() to cxl_add_to_region() Robert Richter
2025-02-07 15:37 ` [PATCH v2 09/18] cxl/region: Factor out code to find the root decoder Robert Richter
2025-02-07 15:37 ` [PATCH v2 10/18] cxl/region: Factor out code to find a root decoder's region Robert Richter
2025-02-07 16:20   ` Gregory Price
2025-02-07 15:37 ` [PATCH v2 11/18] cxl/region: Split region registration into an initialization and adding part Robert Richter
2025-02-07 15:37 ` [PATCH v2 12/18] cxl/region: Use iterator to find the root port in cxl_find_root_decoder() Robert Richter
2025-02-07 15:37 ` [PATCH v2 13/18] cxl/region: Add function to find a port's switch decoder by range Robert Richter
2025-02-07 16:29   ` Gregory Price
2025-02-07 22:22   ` Alison Schofield
2025-02-10 12:31     ` Robert Richter
2025-02-07 15:37 ` [PATCH v2 14/18] cxl/region: Unfold cxl_find_root_decoder() into cxl_endpoint_decoder_initialize() Robert Richter
2025-02-07 15:37 ` [PATCH v2 15/18] cxl/region: Show message on registration failure Robert Richter
2025-02-07 15:37 ` Robert Richter [this message]
2025-02-07 23:36   ` [PATCH v2 16/18] cxl/region: Show message on broken target list Alison Schofield
2025-02-10 12:35     ` Robert Richter
2025-02-07 15:37 ` [PATCH v2 17/18] cxl: Show message when a decoder was added to a port Robert Richter
2025-02-07 15:37 ` [PATCH v2 18/18] cxl/acpi: Unify CFMWS memory log messages with SRAT messages Robert Richter
2025-02-07 16:30   ` Gregory Price
2025-02-07 17:48     ` Robert Richter
2025-02-07 21:24 ` [PATCH v2 00/18] cxl: Address translation support, part 1: Cleanups and refactoring Gregory Price
2025-02-11  8:43   ` Robert Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250207153753.418849-17-rrichter@amd.com \
    --to=rrichter@amd.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=alison.schofield@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=dave@stgolabs.net \
    --cc=fabio.m.de.francesco@linux.intel.com \
    --cc=gourry@gourry.net \
    --cc=ira.weiny@intel.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=terry.bowman@amd.com \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox