Linux CXL
 help / color / mirror / Atom feed
From: Dave Jiang <dave.jiang@intel.com>
To: linux-cxl@vger.kernel.org
Cc: dan.j.williams@intel.com, ira.weiny@intel.com,
	vishal.l.verma@intel.com, alison.schofield@intel.com,
	Jonathan.Cameron@huawei.com, dave@stgolabs.net, jgg@nvidia.com,
	shiju.jose@huawei.com, Li Ming <ming.li@zohomail.com>
Subject: [PATCH v4 03/15] cxl/test: Add Get Supported Features mailbox command support
Date: Fri,  7 Feb 2025 16:37:43 -0700	[thread overview]
Message-ID: <20250207233914.2375110-4-dave.jiang@intel.com> (raw)
In-Reply-To: <20250207233914.2375110-1-dave.jiang@intel.com>

Add cxl-test emulation of Get Supported Features mailbox command.
Currently only adding a test feature with feature identifier of
all f's for testing.

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Acked-by: Dan Williams <dan.j.williams@intel.com>
Reviewed-by: Li Ming <ming.li@zohomail.com>
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
---
 tools/testing/cxl/test/mem.c | 70 ++++++++++++++++++++++++++++++++++++
 1 file changed, 70 insertions(+)

diff --git a/tools/testing/cxl/test/mem.c b/tools/testing/cxl/test/mem.c
index e9494cd446ef..4809a90ff9b6 100644
--- a/tools/testing/cxl/test/mem.c
+++ b/tools/testing/cxl/test/mem.c
@@ -44,6 +44,10 @@ static struct cxl_cel_entry mock_cel[] = {
 		.opcode = cpu_to_le16(CXL_MBOX_OP_GET_SUPPORTED_LOGS),
 		.effect = CXL_CMD_EFFECT_NONE,
 	},
+	{
+		.opcode = cpu_to_le16(CXL_MBOX_OP_GET_SUPPORTED_FEATURES),
+		.effect = CXL_CMD_EFFECT_NONE,
+	},
 	{
 		.opcode = cpu_to_le16(CXL_MBOX_OP_IDENTIFY),
 		.effect = CXL_CMD_EFFECT_NONE,
@@ -1354,6 +1358,69 @@ static int mock_activate_fw(struct cxl_mockmem_data *mdata,
 	return -EINVAL;
 }
 
+#define CXL_VENDOR_FEATURE_TEST							\
+	UUID_INIT(0xffffffff, 0xffff, 0xffff, 0xff, 0xff, 0xff, 0xff, 0xff,	\
+		  0xff, 0xff, 0xff)
+
+static void fill_feature_vendor_test(struct cxl_feat_entry *feat)
+{
+	feat->uuid = CXL_VENDOR_FEATURE_TEST;
+	feat->id = 0;
+	feat->get_feat_size = cpu_to_le16(0x4);
+	feat->set_feat_size = cpu_to_le16(0x4);
+	feat->flags = cpu_to_le32(CXL_FEATURE_F_CHANGEABLE |
+				  CXL_FEATURE_F_DEFAULT_SEL |
+				  CXL_FEATURE_F_SAVED_SEL);
+	feat->get_feat_ver = 1;
+	feat->set_feat_ver = 1;
+	feat->effects = cpu_to_le16(CXL_CMD_CONFIG_CHANGE_COLD_RESET |
+				    CXL_CMD_EFFECTS_VALID);
+}
+
+#define MAX_CXL_TEST_FEATS	1
+
+static int mock_get_supported_features(struct cxl_mockmem_data *mdata,
+				       struct cxl_mbox_cmd *cmd)
+{
+	struct cxl_mbox_get_sup_feats_in *in = cmd->payload_in;
+	struct cxl_mbox_get_sup_feats_out *out = cmd->payload_out;
+	struct cxl_feat_entry *feat;
+	u16 start_idx, count;
+
+	if (cmd->size_out < sizeof(*out)) {
+		cmd->return_code = CXL_MBOX_CMD_RC_PAYLOADLEN;
+		return -EINVAL;
+	}
+
+	/*
+	 * Current emulation only supports 1 feature
+	 */
+	start_idx = le16_to_cpu(in->start_idx);
+	if (start_idx != 0) {
+		cmd->return_code = CXL_MBOX_CMD_RC_INPUT;
+		return -EINVAL;
+	}
+
+	count = le16_to_cpu(in->count);
+	if (count < struct_size(out, ents, 0)) {
+		cmd->return_code = CXL_MBOX_CMD_RC_PAYLOADLEN;
+		return -EINVAL;
+	}
+
+	out->supported_feats = cpu_to_le16(MAX_CXL_TEST_FEATS);
+	cmd->return_code = 0;
+	if (count < struct_size(out, ents, MAX_CXL_TEST_FEATS)) {
+		out->num_entries = 0;
+		return 0;
+	}
+
+	out->num_entries = cpu_to_le16(MAX_CXL_TEST_FEATS);
+	feat = out->ents;
+	fill_feature_vendor_test(feat);
+
+	return 0;
+}
+
 static int cxl_mock_mbox_send(struct cxl_mailbox *cxl_mbox,
 			      struct cxl_mbox_cmd *cmd)
 {
@@ -1439,6 +1506,9 @@ static int cxl_mock_mbox_send(struct cxl_mailbox *cxl_mbox,
 	case CXL_MBOX_OP_ACTIVATE_FW:
 		rc = mock_activate_fw(mdata, cmd);
 		break;
+	case CXL_MBOX_OP_GET_SUPPORTED_FEATURES:
+		rc = mock_get_supported_features(mdata, cmd);
+		break;
 	default:
 		break;
 	}
-- 
2.48.1


  parent reply	other threads:[~2025-02-07 23:39 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-07 23:37 [PATCH v4 00/15] cxl: Add CXL feature commands support via fwctl Dave Jiang
2025-02-07 23:37 ` [PATCH v4 01/15] cxl: Enumerate feature commands Dave Jiang
2025-02-07 23:47   ` Dan Williams
2025-02-08  6:00   ` Li Ming
2025-02-11 17:05   ` Jonathan Cameron
2025-02-07 23:37 ` [PATCH v4 02/15] cxl: Add Get Supported Features command for kernel usage Dave Jiang
2025-02-07 23:56   ` Dan Williams
2025-02-10 17:03     ` Dave Jiang
2025-02-08  6:13   ` Li Ming
2025-02-10 17:06     ` Dave Jiang
2025-02-07 23:37 ` Dave Jiang [this message]
2025-02-07 23:37 ` [PATCH v4 04/15] cxl/mbox: Add GET_FEATURE mailbox command Dave Jiang
2025-02-08  0:12   ` Dan Williams
2025-02-07 23:37 ` [PATCH v4 05/15] cxl/mbox: Add SET_FEATURE " Dave Jiang
2025-02-08  0:21   ` Dan Williams
2025-02-08  6:17   ` Li Ming
2025-02-07 23:37 ` [PATCH v4 06/15] cxl: Setup exclusive CXL features that are reserved for the kernel Dave Jiang
2025-02-08  1:10   ` Dan Williams
2025-02-08  1:16     ` Dave Jiang
2025-02-08  6:22   ` Li Ming
2025-02-10 17:40     ` Dave Jiang
2025-02-10 17:50     ` Dave Jiang
2025-02-11  5:46       ` Li Ming
2025-02-11 16:13         ` Dave Jiang
2025-02-07 23:37 ` [PATCH v4 07/15] cxl: Add FWCTL support to CXL Dave Jiang
2025-02-08  1:24   ` Dan Williams
2025-02-07 23:37 ` [PATCH v4 08/15] cxl: Add support for FWCTL get driver information callback Dave Jiang
2025-02-08  1:25   ` Dan Williams
2025-02-10  6:21   ` Li Ming
2025-02-07 23:37 ` [PATCH v4 09/15] cxl: Move cxl feature command structs to user header Dave Jiang
2025-02-07 23:37 ` [PATCH v4 10/15] cxl: Add support for fwctl RPC command to enable CXL feature commands Dave Jiang
2025-02-08  1:29   ` Dan Williams
2025-02-08  1:34   ` Dan Williams
2025-02-08  7:09   ` Li Ming
2025-02-10 22:31     ` Dave Jiang
2025-02-07 23:37 ` [PATCH v4 11/15] cxl: Add support to handle user feature commands for get feature Dave Jiang
2025-02-10  6:41   ` Li Ming
2025-02-07 23:37 ` [PATCH v4 12/15] cxl: Add support to handle user feature commands for set feature Dave Jiang
2025-02-10  6:43   ` Li Ming
2025-02-07 23:37 ` [PATCH v4 13/15] cxl/test: Add Get Feature support to cxl_test Dave Jiang
2025-02-10  6:44   ` Li Ming
2025-02-07 23:37 ` [PATCH v4 14/15] cxl/test: Add Set " Dave Jiang
2025-02-10  6:44   ` Li Ming
2025-02-07 23:37 ` [PATCH v4 15/15] fwctl/cxl: Add documentation to FWCTL CXL Dave Jiang
2025-02-08  1:38   ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250207233914.2375110-4-dave.jiang@intel.com \
    --to=dave.jiang@intel.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=alison.schofield@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave@stgolabs.net \
    --cc=ira.weiny@intel.com \
    --cc=jgg@nvidia.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=ming.li@zohomail.com \
    --cc=shiju.jose@huawei.com \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox