From: Jason Gunthorpe <jgg@nvidia.com>
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Dave Jiang <dave.jiang@intel.com>,
linux-cxl@vger.kernel.org, dan.j.williams@intel.com,
ira.weiny@intel.com, vishal.l.verma@intel.com,
alison.schofield@intel.com, dave@stgolabs.net,
shiju.jose@huawei.com
Subject: Re: [PATCH v5 10/15] cxl: Add support for fwctl RPC command to enable CXL feature commands
Date: Wed, 12 Feb 2025 19:37:19 -0400 [thread overview]
Message-ID: <20250212233719.GW3754072@nvidia.com> (raw)
In-Reply-To: <20250212175534.000035d5@huawei.com>
On Wed, Feb 12, 2025 at 05:55:34PM +0000, Jonathan Cameron wrote:
> Trivial but could do
>
> return scope >= FWCTL_RPC_CONFIGURATION;
Compiler warns on the tautological comparison. unsigned int cannot be
less than 0 :\
mlx5 wrote it like:
return true; /* scope >= FWCTL_RPC_CONFIGURATION; */
Jason
next prev parent reply other threads:[~2025-02-12 23:37 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-11 18:27 [PATCH v5 00/15] cxl: Add CXL feature commands support via fwctl Dave Jiang
2025-02-11 18:27 ` [PATCH v5 01/15] cxl: Enumerate feature commands Dave Jiang
2025-02-11 18:27 ` [PATCH v5 02/15] cxl: Add Get Supported Features command for kernel usage Dave Jiang
2025-02-11 18:27 ` [PATCH v5 03/15] cxl/test: Add Get Supported Features mailbox command support Dave Jiang
2025-02-11 18:27 ` [PATCH v5 04/15] cxl/mbox: Add GET_FEATURE mailbox command Dave Jiang
2025-02-11 18:27 ` [PATCH v5 05/15] cxl/mbox: Add SET_FEATURE " Dave Jiang
2025-02-12 17:35 ` Jonathan Cameron
2025-02-11 18:28 ` [PATCH v5 06/15] cxl: Setup exclusive CXL features that are reserved for the kernel Dave Jiang
2025-02-11 18:28 ` [PATCH v5 07/15] cxl: Add FWCTL support to CXL Dave Jiang
2025-02-12 17:44 ` Jonathan Cameron
2025-02-12 17:47 ` Jonathan Cameron
2025-02-11 18:28 ` [PATCH v5 08/15] cxl: Add support for FWCTL get driver information callback Dave Jiang
2025-02-12 21:18 ` Saeed Mahameed
2025-02-13 15:32 ` Jason Gunthorpe
2025-02-13 17:29 ` Dave Jiang
2025-02-13 18:33 ` Dan Williams
2025-02-13 18:43 ` Jason Gunthorpe
2025-02-13 17:27 ` Dave Jiang
2025-02-13 18:12 ` Dan Williams
2025-02-13 22:11 ` Dave Jiang
2025-02-13 19:36 ` Jason Gunthorpe
2025-02-13 22:11 ` Dave Jiang
2025-02-11 18:28 ` [PATCH v5 09/15] cxl: Move cxl feature command structs to user header Dave Jiang
2025-02-11 18:28 ` [PATCH v5 10/15] cxl: Add support for fwctl RPC command to enable CXL feature commands Dave Jiang
2025-02-12 17:55 ` Jonathan Cameron
2025-02-12 23:37 ` Jason Gunthorpe [this message]
2025-02-13 2:49 ` Saeed Mahameed
2025-02-13 18:05 ` Jason Gunthorpe
2025-02-13 18:22 ` Dan Williams
2025-02-13 22:16 ` Dave Jiang
2025-02-11 18:28 ` [PATCH v5 11/15] cxl: Add support to handle user feature commands for get feature Dave Jiang
2025-02-11 18:28 ` [PATCH v5 12/15] cxl: Add support to handle user feature commands for set feature Dave Jiang
2025-02-11 18:28 ` [PATCH v5 13/15] cxl/test: Add Get Feature support to cxl_test Dave Jiang
2025-02-11 18:28 ` [PATCH v5 14/15] cxl/test: Add Set " Dave Jiang
2025-02-11 18:28 ` [PATCH v5 15/15] fwctl/cxl: Add documentation to FWCTL CXL Dave Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250212233719.GW3754072@nvidia.com \
--to=jgg@nvidia.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=shiju.jose@huawei.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox