Linux CXL
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: Dave Jiang <dave.jiang@intel.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
	linux-cxl@vger.kernel.org, Li Ming <ming.li@zohomail.com>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH] cxl/fwctl: Cleanup unused fwctl_dev from cxl_features_state
Date: Fri, 7 Mar 2025 19:10:07 -0400	[thread overview]
Message-ID: <20250307231007.GY354511@nvidia.com> (raw)
In-Reply-To: <1d180475-54ae-4095-bb36-f7ec8ee17f7c@intel.com>

On Fri, Mar 07, 2025 at 03:26:02PM -0700, Dave Jiang wrote:
> 
> 
> On 3/7/25 3:11 PM, Dan Williams wrote:
> > A review of devm_cxl_setup_fwctl() indicates a potential a use after
> > free condition for the ->fwctl_dev pointer given it is not cleared after
> > devm_add_action_or_reset() might have released it. However, nothing uses
> > it, so just delete it.
> > 
> > If it ever comes back it should be returned by devm_cxl_setup_fwctl() so
> > that users can always assume the pointer is either valid or NULL.
> > 
> > Cc: Dave Jiang <dave.jiang@intel.com>
> > Cc: Li Ming <ming.li@zohomail.com>
> > Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > Cc: Jason Gunthorpe <jgg@nvidia.com>
> > Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> 
> Reviewed-by: Dave Jiang <dave.jiang@intel.com>

I can squash this into the v8

Thanks,
Jason

      reply	other threads:[~2025-03-07 23:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-07 22:11 [PATCH] cxl/fwctl: Cleanup unused fwctl_dev from cxl_features_state Dan Williams
2025-03-07 22:26 ` Dave Jiang
2025-03-07 23:10   ` Jason Gunthorpe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250307231007.GY354511@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=ming.li@zohomail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox