Linux CXL
 help / color / mirror / Atom feed
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
To: Alison Schofield <alison.schofield@intel.com>
Cc: Davidlohr Bueso <dave@stgolabs.net>,
	Dave Jiang <dave.jiang@intel.com>,
	Vishal Verma <vishal.l.verma@intel.com>,
	Ira Weiny <ira.weiny@intel.com>,
	Dan Williams <dan.j.williams@intel.com>,
	<linux-cxl@vger.kernel.org>
Subject: Re: [PATCH v2] cxl/region: Allow 6 & 12 way regions on 3-way HB interleaves
Date: Tue, 18 Mar 2025 14:35:39 +0000	[thread overview]
Message-ID: <20250318143539.00002575@huawei.com> (raw)
In-Reply-To: <Z9jjqPopE2IF5VXn@aschofie-mobl2.lan>

On Mon, 17 Mar 2025 20:08:24 -0700
Alison Schofield <alison.schofield@intel.com> wrote:

> On Fri, Mar 14, 2025 at 12:00:36PM +0000, Jonathan Cameron wrote:
> > On Thu,  6 Mar 2025 15:22:37 -0800
> > alison.schofield@intel.com wrote:
> >   
> > > From: Alison Schofield <alison.schofield@intel.com>
> > > 
> > > The CXL driver requires the granularity of a region and its root
> > > decoder to be the same. This is particularly restrictive for 3-way
> > > host bridge interleaves where the only spec defined interleave
> > > configurations for creating 6-way and 12-way regions on a 3-way HB
> > > interleave require mixed granularities.
> > > 
> > > CXL 3.2 Specification 9.13.1.1:
> > > Legal Interleaving Configurations: 12-way, 6-way, and 3-way  
> > 
> > Ah this is finally a valid reason to do coarser interleave first
> > (going away from host). That was subject of long discussions way back
> > when original interleaving code was discussed (mostly because
> > my mental model did it that way around and I couldn't follow what
> > the kernel code was doing).
> > 
> > We 'could' revisit allowing this more generally - at least for
> > already configured set ups.  Only real reason for that is
> > either that someone ships a config that does it for a different
> > case, or that we want to avoid special casing 3*x cases.  
> 
> Hi Jonathan,
> 
> I'll bring these configs up as an OPEN at the upcoming community collab,
> and hope you can elaborate more there.
> 

Sure. I'll try and remember how all this worked!

I'm not really suggesting we do handle those other cases unless we know
they are in the wild or it simplifies the code by removing special cases
(I'm not sure it does!)

Jonathan

> --Alison
> 
> 
> > 
> > Jonathan  
> 


      reply	other threads:[~2025-03-18 14:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-06 23:22 [PATCH v2] cxl/region: Allow 6 & 12 way regions on 3-way HB interleaves alison.schofield
2025-03-07  0:23 ` Dan Williams
2025-03-12 16:59   ` Alison Schofield
2025-03-14 12:00 ` Jonathan Cameron
2025-03-18  3:08   ` Alison Schofield
2025-03-18 14:35     ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250318143539.00002575@huawei.com \
    --to=jonathan.cameron@huawei.com \
    --cc=alison.schofield@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=dave@stgolabs.net \
    --cc=ira.weiny@intel.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox