Linux CXL
 help / color / mirror / Atom feed
From: Purva Yeshi <purvayeshi550@gmail.com>
To: dave@stgolabs.net, jonathan.cameron@huawei.com,
	dave.jiang@intel.com, alison.schofield@intel.com,
	vishal.l.verma@intel.com, ira.weiny@intel.com,
	dan.j.williams@intel.com
Cc: ming.li@zohomail.com, huang.ying.caritas@gmail.com,
	linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org,
	Purva Yeshi <purvayeshi550@gmail.com>
Subject: [PATCH] cxl: core: Initialize eiw and eig to fix potential uninitialized use
Date: Sun, 20 Apr 2025 02:05:30 +0530	[thread overview]
Message-ID: <20250419203530.45594-1-purvayeshi550@gmail.com> (raw)

Fix Smatch-detected issue:

drivers/cxl/core/region.c:1292 check_interleave_cap()
error: uninitialized symbol 'eiw'.
drivers/cxl/core/region.c:1297 check_interleave_cap()
error: uninitialized symbol 'eig'.
drivers/cxl/core/region.c:1299 check_interleave_cap()
error: uninitialized symbol 'eig'.

Smatch reports possible uninitialized usage of these variables if
the helper functions ways_to_eiw() or granularity_to_eig() fail to
assign values under certain conditions.

Initialize the eiw and eig variables to zero when they are declared
in check_interleave_cap() to prevent potential use of uninitialized
values.

Signed-off-by: Purva Yeshi <purvayeshi550@gmail.com>
---
 drivers/cxl/core/region.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c
index c3f4dc244df7..edf8636f190a 100644
--- a/drivers/cxl/core/region.c
+++ b/drivers/cxl/core/region.c
@@ -1266,8 +1266,8 @@ static int check_interleave_cap(struct cxl_decoder *cxld, int iw, int ig)
 	struct cxl_port *port = to_cxl_port(cxld->dev.parent);
 	struct cxl_hdm *cxlhdm = dev_get_drvdata(&port->dev);
 	unsigned int interleave_mask;
-	u8 eiw;
-	u16 eig;
+	u8 eiw = 0;
+	u16 eig = 0;
 	int high_pos, low_pos;
 
 	if (!test_bit(iw, &cxlhdm->iw_cap_mask))
-- 
2.34.1


             reply	other threads:[~2025-04-19 20:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-19 20:35 Purva Yeshi [this message]
2025-04-20 10:43 ` [PATCH] cxl: core: Initialize eiw and eig to fix potential uninitialized use Li Ming
2025-04-21 15:40   ` Gregory Price
2025-04-21 15:41 ` Gregory Price
2025-04-21 17:39 ` Dan Williams
2025-05-13 18:52   ` Alison Schofield

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250419203530.45594-1-purvayeshi550@gmail.com \
    --to=purvayeshi550@gmail.com \
    --cc=alison.schofield@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=dave@stgolabs.net \
    --cc=huang.ying.caritas@gmail.com \
    --cc=ira.weiny@intel.com \
    --cc=jonathan.cameron@huawei.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.li@zohomail.com \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox