From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4656728A411; Wed, 7 May 2025 15:15:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746630916; cv=none; b=dDTPExKThYRWikAtrqPwdojGNpuONeZA5e1q5IQvWvKAJ4abvzwjjH0/ISxOtePsnEk/x6Mz7kAufmUh+2IhXKesPYiPUnuVdMCsuTj9ZtNtBBd+8Pk5+rttRKzuF08ZJ4w31jEySDHS78vF0SjhNHpH0VXaaAkjcT3WNxfoTNo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746630916; c=relaxed/simple; bh=6aJyKwDJyYv14UMvQvqVQkM2F5iS184Hqu9roe/nEC8=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=lD8WBW1MGgc4hDxgurE1Wd0YKvfMh8/PJ7tZcSj4HA9lsmkfGBYWxnhXhucQP13mLJ14EYeetH72twV3zrBse0jgLVQbp1rUHYJuuIuv0fDf4rh38FyTWn2Xf5Un54WNKs2CkMBToa+IbOo0ksnlji1xCeryGMTo0YCexR0S0PY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4ZszGm6nRfz6M53M; Wed, 7 May 2025 23:10:40 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 279381402F5; Wed, 7 May 2025 23:15:12 +0800 (CST) Received: from localhost (10.203.177.66) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 7 May 2025 17:15:11 +0200 Date: Wed, 7 May 2025 16:15:10 +0100 From: Jonathan Cameron To: Robert Richter CC: Alison Schofield , Vishal Verma , Ira Weiny , Dan Williams , Dave Jiang , "Davidlohr Bueso" , , , Gregory Price , "Fabio M. De Francesco" , Terry Bowman Subject: Re: [PATCH v5 05/14] cxl/region: Rename function to cxl_port_pick_region_decoder() Message-ID: <20250507161510.00001ee8@huawei.com> In-Reply-To: <20250429163119.00001eba@huawei.com> References: <20250428214318.1682212-1-rrichter@amd.com> <20250428214318.1682212-6-rrichter@amd.com> <20250429163119.00001eba@huawei.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-cxl@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml100003.china.huawei.com (7.191.160.210) To frapeml500008.china.huawei.com (7.182.85.71) On Tue, 29 Apr 2025 16:31:19 +0100 Jonathan Cameron wrote: > On Mon, 28 Apr 2025 23:43:08 +0200 > Robert Richter wrote: > > > Current function cxl_region_find_decoder() is used to find a port's > > decoder during region setup. In the region creation path the function > > is an allocator to find a free port. In the region assembly path, it > > is recalling the decoder that platform firmware picked for validation > > purposes. > > > > Rename function to cxl_port_pick_region_decoder() that better > > describes its use and update the function's description. > > > > The result of cxl_port_pick_region_decoder() is recorded in a 'struct > > cxl_region_ref' in @port for later recall when other endpoints might > > also be targets of the picked decoder. > > I'm not convinced pick is really any clearer than find as it doesn't to me > imply 'get the one that was already allocated'. I'm also not seeing > a lot of precedence in kernel for this use of pick. > > I don't feel that strongly either way though and I guess I'll > get used to the term if we go with pick. > > Alternative might just be to make it an or... > > cxl_region_find_or_alloc_decoder() > Just taking a look at where this series stands and feel a clarification is needed. Note I don't care enough on this to block the series going forwards! > > > > > Signed-off-by: Robert Richter > > Reviewed-by: Gregory Price > > Tested-by: Gregory Price > > --- > > drivers/cxl/core/region.c | 25 ++++++++++++++++++++----- > > 1 file changed, 20 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c > > index e35209168c9c..e104035e0855 100644 > > --- a/drivers/cxl/core/region.c > > +++ b/drivers/cxl/core/region.c > > @@ -865,10 +865,25 @@ static int match_auto_decoder(struct device *dev, const void *data) > > return 0; > > } > > > > +/** > > + * cxl_port_pick_region_decoder() - assign or lookup a decoder for a region > > + * @port: a port in the ancestry of the endpoint implied by @cxled > > + * @cxled: endpoint decoder to be, or currently, mapped by @port > > + * @cxlr: region to establish, or validate, decode @port > > + * > > + * In the region creation path cxl_port_pick_region_decoder() is an > > + * allocator to find a free port. In the region assembly path, it is > > + * recalling the decoder that platform firmware picked for validation > > + * purposes. > > + * > > + * The result is recorded in a 'struct cxl_region_ref' in @port for > > + * later recall when other endpoints might also be targets of the picked > > + * decoder. > > + */ > > static struct cxl_decoder * > > -cxl_region_find_decoder(struct cxl_port *port, > > - struct cxl_endpoint_decoder *cxled, > > - struct cxl_region *cxlr) > > +cxl_port_pick_region_decoder(struct cxl_port *port, > > + struct cxl_endpoint_decoder *cxled, > > + struct cxl_region *cxlr) > > { > > struct device *dev; > > > > @@ -932,7 +947,7 @@ alloc_region_ref(struct cxl_port *port, struct cxl_region *cxlr, > > if (test_bit(CXL_REGION_F_AUTO, &cxlr->flags)) { > > struct cxl_decoder *cxld; > > > > - cxld = cxl_region_find_decoder(port, cxled, cxlr); > > + cxld = cxl_port_pick_region_decoder(port, cxled, cxlr); > > if (auto_order_ok(port, iter->region, cxld)) > > continue; > > } > > @@ -1020,7 +1035,7 @@ static int cxl_rr_alloc_decoder(struct cxl_port *port, struct cxl_region *cxlr, > > { > > struct cxl_decoder *cxld; > > > > - cxld = cxl_region_find_decoder(port, cxled, cxlr); > > + cxld = cxl_port_pick_region_decoder(port, cxled, cxlr); > > if (!cxld) { > > dev_dbg(&cxlr->dev, "%s: no decoder available\n", > > dev_name(&port->dev)); > >