From: Arpit Kumar <arpit1.kumar@samsung.com>
To: qemu-devel@nongnu.org
Cc: gost.dev@samsung.com, linux-cxl@vger.kernel.org,
nifan.cxl@gmail.com, dave@stgolabs.net, vishak.g@samsung.com,
krish.reddy@samsung.com, a.manzanares@samsung.com,
alok.rathore@samsung.com, Arpit Kumar <arpit1.kumar@samsung.com>
Subject: [PATCH 1/3] hw/cxl: Storing physical ports info during enumeration
Date: Mon, 2 Jun 2025 19:29:40 +0530 [thread overview]
Message-ID: <20250602135942.2773823-2-arpit1.kumar@samsung.com> (raw)
In-Reply-To: <20250602135942.2773823-1-arpit1.kumar@samsung.com>
Physical ports info is stored for both mailbox cci &
mctp based cci type as per spec CXL r3.2 Table 8-230: Physical Switch
Signed-off-by: Arpit Kumar <arpit1.kumar@samsung.com>
---
hw/cxl/cxl-mailbox-utils.c | 166 ++++++++++++++++++++++++++++++++++++
include/hw/cxl/cxl_device.h | 28 ++++++
2 files changed, 194 insertions(+)
diff --git a/hw/cxl/cxl-mailbox-utils.c b/hw/cxl/cxl-mailbox-utils.c
index a02d130926..680055c6c0 100644
--- a/hw/cxl/cxl-mailbox-utils.c
+++ b/hw/cxl/cxl-mailbox-utils.c
@@ -124,6 +124,64 @@ enum {
#define GET_MHD_INFO 0x0
};
+/* link state flags */
+#define LINK_STATE_FLAG_LANE_REVERSED (1 << 0)
+#define LINK_STATE_FLAG_PERST_ASSERTED (1 << 1)
+#define LINK_STATE_FLAG_PRSNT (1 << 2)
+#define LINK_STATE_FLAG_POWER_OFF (1 << 3)
+
+/* physical port control info - CXL r3.2 table 7-19 */
+typedef enum {
+ PORT_DISABLED = 0,
+ BIND_IN_PROGRESS = 1,
+ UNBIND_IN_PROGRESS = 2,
+ DSP = 3,
+ USP = 4,
+ FABRIC_PORT = 5,
+ INVALID_PORT_ID = 15
+} current_port_config_state;
+
+typedef enum {
+ NOT_CXL_OR_DISCONNECTED = 0x00,
+ RCD_MODE = 0x01,
+ CXL_68B_FLIT_AND_VH_MODE = 0x02,
+ STANDARD_256B_FLIT_MODE = 0x03,
+ CXL_LATENCY_OPTIMIZED_256B_FLIT_MODE = 0x04,
+ PBR_MODE = 0x05
+} connected_device_mode;
+
+typedef enum {
+ NO_DEVICE_DETECTED = 0,
+ PCIE_DEVICE = 1,
+ CXL_TYPE_1_DEVICE = 2,
+ CXL_TYPE_2_DEVICE_OR_HBR_SWITCH = 3,
+ CXL_TYPE_3_SLD = 4,
+ CXL_TYPE_3_MLD = 5,
+ PBR_COMPONENT = 6
+} connected_device_type;
+
+typedef enum {
+ CXL_RCD_MODE = 0x00,
+ CXL_68B_FLIT_AND_VH_CAPABLE = 0x01,
+ CXL_256B_FLIT_CAPABLE = 0x02,
+ CXL_LATENCY_OPTIMIZED_256B_FLIT = 0x03,
+ CXL_PBR_CAPABLE = 0x04
+} supported_cxl_modes;
+
+typedef enum {
+ LTSSM_DETECT = 0x00,
+ LTSSM_POLLING = 0x01,
+ LTSSM_CONFIGURATION = 0x02,
+ LTSSM_RECOVERY = 0x03,
+ LTSSM_L0 = 0x04,
+ LTSSM_L0S = 0x05,
+ LTSSM_L1 = 0x06,
+ LTSSM_L2 = 0x07,
+ LTSSM_DISABLED = 0x08,
+ LTSSM_LOOPBACK = 0x09,
+ LTSSM_HOT_RESET = 0x0A
+} LTSSM_State;
+
/* CCI Message Format CXL r3.1 Figure 7-19 */
typedef struct CXLCCIMessage {
uint8_t category;
@@ -3686,6 +3744,112 @@ void cxl_add_cci_commands(CXLCCI *cci, const struct cxl_cmd (*cxl_cmd_set)[256],
cxl_rebuild_cel(cci);
}
+static CXLRetCode cxl_set_port_type(struct phy_port *ports, int pnum,
+ CXLCCI *cci)
+{
+ PCIDevice *port_dev;
+ uint16_t lnkcap, lnkcap2, lnksta;
+ int i = pnum;
+ if (!cci) {
+ return CXL_MBOX_INTERNAL_ERROR;
+ }
+
+ PCIBus *bus = &PCI_BRIDGE(cci->d)->sec_bus;
+ PCIEPort *usp = PCIE_PORT(cci->d);
+ port_dev = pcie_find_port_by_pn(bus, i);
+
+ if (port_dev) { /* DSP */
+ PCIDevice *ds_dev = pci_bridge_get_sec_bus(PCI_BRIDGE(port_dev))
+ ->devices[0];
+ ports->pport_info[i].port_id = i;
+ ports->pport_info[i].current_port_config_state = DSP;
+ ports->active_port_bitmask[i / 8] |= (1 << i % 8);
+ if (ds_dev) {
+ if (object_dynamic_cast(OBJECT(ds_dev), TYPE_CXL_TYPE3)) {
+ ports->pport_info[i].connected_device_type = CXL_TYPE_3_MLD;
+ } else {
+ ports->pport_info[i].connected_device_type = PCIE_DEVICE;
+ }
+ } else {
+ ports->pport_info[i].connected_device_type = NO_DEVICE_DETECTED;
+ }
+ ports->pport_info[i].supported_ld_count = 3;
+ } else if (usp->port == i) { /* USP */
+ port_dev = PCI_DEVICE(usp);
+ ports->pport_info[i].port_id = i;
+ ports->pport_info[i].current_port_config_state = USP;
+ ports->pport_info[i].connected_device_type = NO_DEVICE_DETECTED;
+ ports->active_port_bitmask[i / 8] |= (1 << i % 8);
+ } else {
+ return CXL_MBOX_INVALID_INPUT;
+ }
+
+ if (!port_dev->exp.exp_cap) {
+ return CXL_MBOX_INTERNAL_ERROR;
+ }
+
+ lnksta = port_dev->config_read(port_dev,
+ port_dev->exp.exp_cap + PCI_EXP_LNKSTA,
+ sizeof(lnksta));
+ lnkcap = port_dev->config_read(port_dev,
+ port_dev->exp.exp_cap + PCI_EXP_LNKCAP,
+ sizeof(lnkcap));
+ lnkcap2 = port_dev->config_read(port_dev,
+ port_dev->exp.exp_cap + PCI_EXP_LNKCAP2,
+ sizeof(lnkcap2));
+
+ ports->pport_info[i].max_link_width = (lnkcap & PCI_EXP_LNKCAP_MLW) >> 4;
+ ports->pport_info[i].negotiated_link_width = (lnksta & PCI_EXP_LNKSTA_NLW) >> 4;
+ ports->pport_info[i].supported_link_speeds_vector = (lnkcap2 & 0xFE) >> 1;
+ ports->pport_info[i].max_link_speed = lnkcap & PCI_EXP_LNKCAP_SLS;
+ ports->pport_info[i].current_link_speed = lnksta & PCI_EXP_LNKSTA_CLS;
+
+ ports->pport_info[i].ltssm_state = LTSSM_L2;
+ ports->pport_info[i].first_negotiated_lane_num = 0;
+ ports->pport_info[i].link_state_flags = 0;
+ ports->pport_info[i].supported_cxl_modes = CXL_256B_FLIT_CAPABLE;
+ ports->pport_info[i].connected_device_mode = STANDARD_256B_FLIT_MODE;
+
+ return CXL_MBOX_SUCCESS;
+}
+
+static CXLRetCode cxl_set_phy_port_info(CXLCCI *cci)
+{
+ uint8_t phy_port_num;
+ if (!cci) {
+ return CXL_MBOX_INTERNAL_ERROR;
+ }
+
+ PCIEPort *usp = PCIE_PORT(cci->d);
+ PCIBus *bus = &PCI_BRIDGE(cci->d)->sec_bus;
+ struct phy_port *ports = &cci->pports;
+ int num_phys_ports = pcie_count_ds_ports(bus) + 1;
+ if (num_phys_ports < 0) {
+ return CXL_MBOX_INTERNAL_ERROR;
+ }
+
+ ports->num_ports = num_phys_ports;
+ phy_port_num = usp->port;
+
+ cxl_set_port_type(ports, phy_port_num, cci); /* usp */
+
+ for (int devfn = 0; devfn < ARRAY_SIZE(bus->devices); devfn++) {
+ PCIDevice *dev = bus->devices[devfn];
+
+ if (dev) {
+ phy_port_num = PCIE_PORT(dev)->port;
+ const char *typename = object_get_typename(OBJECT(dev));
+
+ if ((strcmp(typename, "cxl-downstream") == 0)) {
+ cxl_set_port_type(ports, phy_port_num, cci);
+ } else {
+ return CXL_MBOX_INTERNAL_ERROR;
+ }
+ }
+ }
+ return CXL_MBOX_SUCCESS;
+}
+
void cxl_initialize_mailbox_swcci(CXLCCI *cci, DeviceState *intf,
DeviceState *d, size_t payload_max)
{
@@ -3693,6 +3857,7 @@ void cxl_initialize_mailbox_swcci(CXLCCI *cci, DeviceState *intf,
cci->d = d;
cci->intf = intf;
cxl_init_cci(cci, payload_max);
+ cxl_set_phy_port_info(cci); /* store port info */
}
void cxl_initialize_mailbox_t3(CXLCCI *cci, DeviceState *d, size_t payload_max)
@@ -3797,4 +3962,5 @@ void cxl_initialize_usp_mctpcci(CXLCCI *cci, DeviceState *d, DeviceState *intf,
cci->d = d;
cci->intf = intf;
cxl_init_cci(cci, payload_max);
+ cxl_set_phy_port_info(cci); /* store port info */
}
diff --git a/include/hw/cxl/cxl_device.h b/include/hw/cxl/cxl_device.h
index ca515cab13..9eb128a1e8 100644
--- a/include/hw/cxl/cxl_device.h
+++ b/include/hw/cxl/cxl_device.h
@@ -127,6 +127,31 @@
CXL_NUM_CHMU_INSTANCES * (1 << 16), \
(1 << 16))
+/* CXL r3.2 Table 7-19: Port Info */
+struct cxl_phy_port_info {
+ uint8_t port_id;
+ uint8_t current_port_config_state;
+ uint8_t connected_device_mode;
+ uint8_t rsv1;
+ uint8_t connected_device_type;
+ uint8_t supported_cxl_modes;
+ uint8_t max_link_width;
+ uint8_t negotiated_link_width;
+ uint8_t supported_link_speeds_vector;
+ uint8_t max_link_speed;
+ uint8_t current_link_speed;
+ uint8_t ltssm_state;
+ uint8_t first_negotiated_lane_num;
+ uint16_t link_state_flags;
+ uint8_t supported_ld_count;
+} QEMU_PACKED;
+
+struct phy_port {
+ uint8_t num_ports;
+ uint8_t active_port_bitmask[0x20];
+ struct cxl_phy_port_info pport_info[PCI_DEVFN_MAX];
+};
+
/* CXL r3.1 Table 8-34: Command Return Codes */
typedef enum {
CXL_MBOX_SUCCESS = 0x0,
@@ -223,6 +248,9 @@ typedef struct CXLCCI {
/* get log capabilities */
const CXLLogCapabilities *supported_log_cap;
+ /*physical ports information */
+ struct phy_port pports;
+
/* background command handling (times in ms) */
struct {
uint16_t opcode;
--
2.34.1
next prev parent reply other threads:[~2025-06-02 16:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250602140008epcas5p25fce01492de105da3cdc0aaa533f6ebc@epcas5p2.samsung.com>
2025-06-02 13:59 ` [PATCH 0/3] FM-API Physical switch command set update Arpit Kumar
2025-06-02 13:59 ` Arpit Kumar [this message]
2025-06-10 14:21 ` [PATCH 1/3] hw/cxl: Storing physical ports info during enumeration Jonathan Cameron
2025-06-17 9:46 ` Arpit Kumar
2025-06-18 11:31 ` Jonathan Cameron
2025-06-02 13:59 ` [PATCH 2/3] hw/cxl: Simplified Identify Switch Device & Get Physical Port State Arpit Kumar
2025-06-10 14:29 ` Jonathan Cameron
2025-06-17 10:01 ` Arpit Kumar
2025-06-02 13:59 ` [PATCH 3/3] hw/cxl: Add Physical Port Control (Opcode 5102h) Arpit Kumar
2025-06-10 14:45 ` Jonathan Cameron
2025-06-17 10:11 ` Arpit Kumar
2025-06-18 11:32 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250602135942.2773823-2-arpit1.kumar@samsung.com \
--to=arpit1.kumar@samsung.com \
--cc=a.manzanares@samsung.com \
--cc=alok.rathore@samsung.com \
--cc=dave@stgolabs.net \
--cc=gost.dev@samsung.com \
--cc=krish.reddy@samsung.com \
--cc=linux-cxl@vger.kernel.org \
--cc=nifan.cxl@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=vishak.g@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox