From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1CC73241671 for ; Wed, 9 Jul 2025 20:36:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752093387; cv=none; b=qfSxgAnyL4Hh5fKvdcRqkbOS626iWijp3vNgvYCOXyxtOIN4mwON5rjyg4cbmU7TaPHCtul83eGDhLzurezys77TDChTbE6z1d+Ol03CgUEVWNAog5HE5B1raTeE0gc3MSNYTR0/Iq6eEGQJlk2eDSMCRKtPv+iel3TuaT0Lykc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752093387; c=relaxed/simple; bh=HkRMufFei+tfu9b1tSOKx3CrgWNwTeFZwR2xKevh39o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fiDmT5bIMI4S7+RBfP/tBMyAG7ltR7cOPb1E7c7eEl7uimjO3jONHZCChCO9bP0ixv2DV8RRAxlVycNlpJCoxm4G5CE08xWSUKOoE8Ac2hVXtvUmqJnXwsbkNyBa434meJikZKh13s/qfCJIOOjG9El/8pjvAU+jSn/6pb25tSY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 953A8C4CEEF; Wed, 9 Jul 2025 20:36:26 +0000 (UTC) From: Dave Jiang To: linux-cxl@vger.kernel.org Cc: dave@stgolabs.net, jonathan.cameron@huawei.com, alison.schofield@intel.com, vishal.l.verma@intel.com, ira.weiny@intel.com, dan.j.williams@intel.com Subject: [PATCH v6 03/10] cxl: Add helper to reap dport Date: Wed, 9 Jul 2025 13:36:12 -0700 Message-ID: <20250709203619.2607133-4-dave.jiang@intel.com> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250709203619.2607133-1-dave.jiang@intel.com> References: <20250709203619.2607133-1-dave.jiang@intel.com> Precedence: bulk X-Mailing-List: linux-cxl@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Refactor the code in reap_dports() out to provide a helper function that reaps a single dport. This will be used later in the cleanup path for allocating a dport. Reviewed-by: Jonathan Cameron Signed-off-by: Dave Jiang --- drivers/cxl/core/port.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/cxl/core/port.c b/drivers/cxl/core/port.c index a49491c14d19..9691da831224 100644 --- a/drivers/cxl/core/port.c +++ b/drivers/cxl/core/port.c @@ -1447,6 +1447,13 @@ static void delete_switch_port(struct cxl_port *port) devm_release_action(port->dev.parent, unregister_port, port); } +static void reap_dport(struct cxl_port *port, struct cxl_dport *dport) +{ + devm_release_action(&port->dev, cxl_dport_unlink, dport); + devm_release_action(&port->dev, cxl_dport_remove, dport); + devm_kfree(&port->dev, dport); +} + static void reap_dports(struct cxl_port *port) { struct cxl_dport *dport; @@ -1454,11 +1461,8 @@ static void reap_dports(struct cxl_port *port) device_lock_assert(&port->dev); - xa_for_each(&port->dports, index, dport) { - devm_release_action(&port->dev, cxl_dport_unlink, dport); - devm_release_action(&port->dev, cxl_dport_remove, dport); - devm_kfree(&port->dev, dport); - } + xa_for_each(&port->dports, index, dport) + reap_dport(port, dport); } struct detach_ctx { -- 2.50.0