Re: [PATCH V3 12/20] nvdimm/region_label: Export routine to fetch region information

Neeraj Kumar
2025-10-06T04:53:10Z

[-- Attachment #1: Type: text/plain, Size: 584 bytes --]

On 23/09/25 01:23PM, Dave Jiang wrote:
>
>
>On 9/17/25 6:41 AM, Neeraj Kumar wrote:
>> +bool nvdimm_has_cxl_region(struct nvdimm *nvdimm)
>> +{
>> + if (nvdimm)
>> + return nvdimm->is_region_label;
>> +
>> + return false;
>
>Just a nit. Would prefer return error early and return the success case last.
>
>> +}
>> +EXPORT_SYMBOL_GPL(nvdimm_has_cxl_region);
>> +
>> +void *nvdimm_get_cxl_region_param(struct nvdimm *nvdimm)
>> +{
>> + if (nvdimm)
>> + return &nvdimm->cxl_region_params;
>> +
>> + return NULL;
>
>same comment
>

Sure Dave, Will fix it accordingly

Regards,
Neeraj

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]