Re: [PATCH V3 05/20] nvdimm/namespace_label: Add namespace label changes as per CXL LSA v2.1

Neeraj Kumar
2025-09-22T15:53:06Z

[-- Attachment #1: Type: text/plain, Size: 898 bytes --]

On 19/09/25 05:00PM, Ira Weiny wrote:
>Neeraj Kumar wrote:
>> CXL 3.2 Spec mentions CXL LSA 2.1 Namespace Labels at section 9.13.2.5
>> Modified __pmem_label_update function using setter functions to update
>> namespace label as per CXL LSA 2.1
>
>Again I'm curious as to why?
>
>Is it to be able to use the setter's later? I see a call to
>nsl_set_type() added later in the series but then deleted in an even later
>patch. (??)
>
>I don't have time ATM to really follow this through but giving a why in
>the commit message may have made this a simple patch to review. Now I'm
>not clear if it is ok or not.

Hi Ira,

Yes these setter functions are required because of namespace
modifications as per LSA 2.1.

Actually it looks deleted due to refactoring of __pmem_label_update() in
later patch.

I got your point, I will re-arrange it after __pmem_label_update() refactoring.

Regards,
Neeraj

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]