Re: [ndctl PATCH v3] cxl: Add cxl-translate.sh unit test

Alison Schofield
2025-11-10T01:46:45Z

On Tue, Nov 04, 2025 at 06:42:40PM -0800, Marc Herbert wrote:

Marc,
Thanks for the review. I applied all your suggestions in v4.

>
> > [ 'cxl-qos-class.sh', cxl_qos_class, 'cxl' ],
> > [ 'cxl-poison.sh', cxl_poison, 'cxl' ],
> > + [ 'cxl-translate.sh', cxl_translate, 'cxl' ],
> > ]
>
> Just FYI: this now conflicts with b26e9ae3b1dc. I got very confused
> because I was missing a commit and kept looking for the correct
> "pending" branch when in fact it's v3 missing a commit, not me.
> Also, I forgot how clueless "git am" is. Even "patch" is better.
>

Sorry for not including a base-commit in that patch.

> These lists are a regular source of conflicts when all the activity
> always happens at the end. Defining some sort of order (alphabetical or
> whatever) reduces the frequency of conflicts considerably.

I've started mulling this over. Alphabetical caught my attention
because as our list of tests grows :) :) :) scanning the results
in order appeals to me. The part that is not so obvious is that the
execution list is not built strictly from one list. And, off course,
when there is a conflict because more than one test was recently added,
it's usually a simple and nice conflict to resolve.