Re: [PATCH v19 06/22] cxl: Move pci generic code

Jonathan Cameron
2025-11-11T13:41:49Z

On Mon, 10 Nov 2025 11:23:53 +0000
Alejandro Lucero Palau <alucerop@amd.com> wrote:

> On 10/7/25 14:01, Jonathan Cameron wrote:
> > On Mon, 6 Oct 2025 11:01:14 +0100
> > alejandro.lucero-palau@amd.com wrote:
> >
> >> From: Alejandro Lucero <alucerop@amd.com>
> >>
> >> Inside cxl/core/pci.c there are helpers for CXL PCIe initialization
> >> meanwhile cxl/pci.c implements the functionality for a Type3 device
> >> initialization.
> >>
> >> Move helper functions from cxl/pci.c to cxl/core/pci.c in order to be
> >> exported and shared with CXL Type2 device initialization.
> >>
> >> Fix cxl mock tests affected by the code move, deleting a function which
> >> indeed was not being used since commit 733b57f262b0("cxl/pci: Early
> >> setup RCH dport component registers from RCRB").
> >>
> > Trivial but can we pull out that code removal as a separate patch?
> > It's something Dave would probably pick up immediately.
>
>
> The justification for the removal comes from the changes introduced in
> this patch, so I think it should be fine to keep it as it is now, but if
> Dave prefers, I will do so. Not going it for v20 though.
Ok. My confusion is this commit message says the function was not being
used since commit ...
Which isn't this patch. Either that is true and the removal is unrelated
or that description needs a tweak.

Jonathan