Re: [PATCH v19 07/22] cxl: allow Type2 drivers to map cxl component regs

Alejandro Lucero Palau
2025-11-10T11:28:12Z

On 10/7/25 14:18, Jonathan Cameron wrote:
> On Mon, 6 Oct 2025 11:01:15 +0100
> alejandro.lucero-palau@amd.com wrote:
>
>> From: Alejandro Lucero <alucerop@amd.com>
>>
> I'd amend the patch title to
> cxl/sfc: Map CXL component regs.
>
> And talk about exports in the description.
>
> Other options are fine but the patch title should indicate
> this is being used by the sfc driver.

Yes. I'll do so.

Thanks

>> Export cxl core functions for a Type2 driver being able to discover and
>> map the device component registers.
>>
>> Use it in sfc driver cxl initialization.
>>
>> Signed-off-by: Alejandro Lucero <alucerop@amd.com>
>> Reviewed-by: Dan Williams <dan.j.williams@intel.com>
>> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>> Reviewed-by: Dave Jiang <dave.jiang@intel.com>
>> Reviewed-by: Ben Cheatham <benjamin.cheatham@amd.com>
>> ---
>> drivers/cxl/core/pci.c | 1 +
>> drivers/cxl/core/port.c | 1 +
>> drivers/cxl/core/regs.c | 1 +
>> drivers/cxl/cxl.h | 7 ------
>> drivers/cxl/cxlpci.h | 12 ----------
>> drivers/cxl/pci.c | 1 +
>> drivers/net/ethernet/sfc/efx_cxl.c | 35 ++++++++++++++++++++++++++++++
>> include/cxl/cxl.h | 19 ++++++++++++++++
>> include/cxl/pci.h | 21 ++++++++++++++++++
>> 9 files changed, 79 insertions(+), 19 deletions(-)
>> create mode 100644 include/cxl/pci.h