Re: [PATCH 3/6 v6] acpi/ghes: Make GHES select ACPI_APEI_PCIEAER

[kernel test robot <lkp@intel.com>]

Hi Fabio,

kernel test robot noticed the following build errors:

[auto build test ERROR on 552c50713f273b494ac6c77052032a49bc9255e2]

url:    https://github.com/intel-lab-lkp/linux/commits/Fabio-M-De-Francesco/ACPI-extlog-Trace-CPER-Non-standard-Section-Body/20251023-202846
base:   552c50713f273b494ac6c77052032a49bc9255e2
patch link:    https://lore.kernel.org/r/20251023122612.1326748-4-fabio.m.de.francesco%40linux.intel.com
patch subject: [PATCH 3/6 v6] acpi/ghes: Make GHES select ACPI_APEI_PCIEAER
config: x86_64-buildonly-randconfig-004-20251023 (https://download.01.org/0day-ci/archive/20251023/202510232204.XIXgPWD7-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251023/202510232204.XIXgPWD7-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202510232204.XIXgPWD7-lkp@intel.com/

All errors (new ones prefixed by >>):

   ld: vmlinux.o: in function `ghes_handle_aer':
>> drivers/acpi/apei/ghes.c:626:(.text+0xf13e77): undefined reference to `cper_severity_to_aer'
>> ld: drivers/acpi/apei/ghes.c:642:(.text+0xf13f76): undefined reference to `aer_recover_queue'
   ld: vmlinux.o: in function `cxl_cper_post_prot_err':
   drivers/acpi/apei/ghes.c:753:(.text+0xf14cef): undefined reference to `cper_severity_to_aer'

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for ACPI_APEI_PCIEAER
   Depends on [n]: ACPI [=y] && ACPI_APEI [=y] && PCIEAER [=n]
   Selected by [y]:
   - ACPI_APEI_GHES [=y] && ACPI [=y] && ACPI_APEI [=y]


vim +626 drivers/acpi/apei/ghes.c

cf870c70a19444 Naveen N Rao 2013-07-10  599  
9852ce9ae213d3 Tyler Baicar 2017-11-28  600  /*
9852ce9ae213d3 Tyler Baicar 2017-11-28  601   * PCIe AER errors need to be sent to the AER driver for reporting and
9852ce9ae213d3 Tyler Baicar 2017-11-28  602   * recovery. The GHES severities map to the following AER severities and
9852ce9ae213d3 Tyler Baicar 2017-11-28  603   * require the following handling:
9852ce9ae213d3 Tyler Baicar 2017-11-28  604   *
9852ce9ae213d3 Tyler Baicar 2017-11-28  605   * GHES_SEV_CORRECTABLE -> AER_CORRECTABLE
9852ce9ae213d3 Tyler Baicar 2017-11-28  606   *     These need to be reported by the AER driver but no recovery is
9852ce9ae213d3 Tyler Baicar 2017-11-28  607   *     necessary.
9852ce9ae213d3 Tyler Baicar 2017-11-28  608   * GHES_SEV_RECOVERABLE -> AER_NONFATAL
9852ce9ae213d3 Tyler Baicar 2017-11-28  609   * GHES_SEV_RECOVERABLE && CPER_SEC_RESET -> AER_FATAL
9852ce9ae213d3 Tyler Baicar 2017-11-28  610   *     These both need to be reported and recovered from by the AER driver.
9852ce9ae213d3 Tyler Baicar 2017-11-28  611   * GHES_SEV_PANIC does not make it to this handling since the kernel must
9852ce9ae213d3 Tyler Baicar 2017-11-28  612   *     panic.
9852ce9ae213d3 Tyler Baicar 2017-11-28  613   */
9852ce9ae213d3 Tyler Baicar 2017-11-28  614  static void ghes_handle_aer(struct acpi_hest_generic_data *gdata)
d334a49113a4a3 Ying Huang   2010-05-18  615  {
bbcc2e7b642ed2 Tyler Baicar 2017-06-21  616  	struct cper_sec_pcie *pcie_err = acpi_hest_get_payload(gdata);
bbcc2e7b642ed2 Tyler Baicar 2017-06-21  617  
9852ce9ae213d3 Tyler Baicar 2017-11-28  618  	if (pcie_err->validation_bits & CPER_PCIE_VALID_DEVICE_ID &&
a654e5ee4f2213 Ying Huang   2011-12-08  619  	    pcie_err->validation_bits & CPER_PCIE_VALID_AER_INFO) {
a654e5ee4f2213 Ying Huang   2011-12-08  620  		unsigned int devfn;
a654e5ee4f2213 Ying Huang   2011-12-08  621  		int aer_severity;
e2abc47a5a1a9f Shiju Jose   2023-09-21  622  		u8 *aer_info;
0ba98ec9196746 Betty Dall   2013-06-06  623  
a654e5ee4f2213 Ying Huang   2011-12-08  624  		devfn = PCI_DEVFN(pcie_err->device_id.device,
a654e5ee4f2213 Ying Huang   2011-12-08  625  				  pcie_err->device_id.function);
2458d66b245e39 Tyler Baicar 2016-09-14 @626  		aer_severity = cper_severity_to_aer(gdata->error_severity);
0ba98ec9196746 Betty Dall   2013-06-06  627  
0ba98ec9196746 Betty Dall   2013-06-06  628  		/*
0ba98ec9196746 Betty Dall   2013-06-06  629  		 * If firmware reset the component to contain
0ba98ec9196746 Betty Dall   2013-06-06  630  		 * the error, we must reinitialize it before
0ba98ec9196746 Betty Dall   2013-06-06  631  		 * use, so treat it as a fatal AER error.
0ba98ec9196746 Betty Dall   2013-06-06  632  		 */
0ba98ec9196746 Betty Dall   2013-06-06  633  		if (gdata->flags & CPER_SEC_RESET)
0ba98ec9196746 Betty Dall   2013-06-06  634  			aer_severity = AER_FATAL;
0ba98ec9196746 Betty Dall   2013-06-06  635  
e2abc47a5a1a9f Shiju Jose   2023-09-21  636  		aer_info = (void *)gen_pool_alloc(ghes_estatus_pool,
e2abc47a5a1a9f Shiju Jose   2023-09-21  637  						  sizeof(struct aer_capability_regs));
e2abc47a5a1a9f Shiju Jose   2023-09-21  638  		if (!aer_info)
e2abc47a5a1a9f Shiju Jose   2023-09-21  639  			return;
e2abc47a5a1a9f Shiju Jose   2023-09-21  640  		memcpy(aer_info, pcie_err->aer_info, sizeof(struct aer_capability_regs));
e2abc47a5a1a9f Shiju Jose   2023-09-21  641  
a654e5ee4f2213 Ying Huang   2011-12-08 @642  		aer_recover_queue(pcie_err->device_id.segment,
a654e5ee4f2213 Ying Huang   2011-12-08  643  				  pcie_err->device_id.bus,
37448adfc7ce0d Lance Ortiz  2013-05-30  644  				  devfn, aer_severity,
37448adfc7ce0d Lance Ortiz  2013-05-30  645  				  (struct aer_capability_regs *)
e2abc47a5a1a9f Shiju Jose   2023-09-21  646  				  aer_info);
a654e5ee4f2213 Ying Huang   2011-12-08  647  	}
3c5b977f06b754 Tyler Baicar 2017-11-28  648  }
a654e5ee4f2213 Ying Huang   2011-12-08  649  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki