Re: [PATCH v4 01/29] Revert "treewide: Fix probing of devices in DT overlays"

Herve Codina
2026-01-12T14:47:55Z

Hi Saravana,

(+To Saravana using his new email address)

We still have issues related to devlink and overlays.

In order to move forward on the topic, I think I need your help.

Can you have a look and share any ideas to fix them?

On Thu, 11 Dec 2025 16:19:02 +0100
Herve Codina <herve.codina@bootlin.com> wrote:
...
>
> IMHO, I think the issue is related to overlays and fw_devlink.
> The distinction between "a new node is going to lead to a device" vs "a new
> node is just data and will never been attached to a new device" when an
> overlay is applied is broken.
>
> This is broken with the upstream "treewide: Fix probing of devices in DT
> overlays" commit I've tried to revert. Indeed, on the LAN966x PCI device
> use case devlinks created are not correct with this commit applied.
>
> I am not sure also that devlinks created with a more complex overlay will be
> correct. For instance, Matti, with your overlay not sure that a phandle from
> the oscillator node referencing the pmic node will lead to a correct
> provider/consumer devlink between the pmic device and the oscillator device.
>
> On the other hand, this is broken with "of: dynamic: Fix overlayed devices
> not probing because of fw_devlink" works for the LAN966x PCI device use case
> an lead to correct devlinks but breaks your use cases.
>
> Does anyone have an idea about how to fix those issues?
>

The commit "of: dynamic: Fix overlayed devices not probing because of fw_devlink"
can be found in this series (patch 3)
https://lore.kernel.org/all/20251015071420.1173068-4-herve.codina@bootlin.com/

Best regards,
Hervé