Re: [RESEND v13 00/25] Enable CXL PCIe Port Protocol Error handling and logging

Bjorn Helgaas
2025-11-04T22:12:02Z

On Tue, Nov 04, 2025 at 03:54:21PM -0600, Bowman, Terry wrote:
>
>
> On 11/4/2025 1:11 PM, Bjorn Helgaas wrote:
> > On Tue, Nov 04, 2025 at 11:02:40AM -0600, Terry Bowman wrote:
> >> This patchset updates CXL Protocol Error handling for CXL Ports and CXL
> >> Endpoints (EP). Previous versions of this series can be found here:
> >> https://lore.kernel.org/linux-cxl/20250925223440.3539069-1-terry.bowman@amd.com/
> >> ...
> >> Terry Bowman (24):
> >> CXL/PCI: Move CXL DVSEC definitions into uapi/linux/pci_regs.h
> >> PCI/CXL: Introduce pcie_is_cxl()
> >> cxl/pci: Remove unnecessary CXL Endpoint handling helper functions
> >> cxl/pci: Remove unnecessary CXL RCH handling helper functions
> >> cxl: Move CXL driver's RCH error handling into core/ras_rch.c
> >> CXL/AER: Replace device_lock() in cxl_rch_handle_error_iter() with
> >> guard() lock
> >> CXL/AER: Move AER drivers RCH error handling into pcie/aer_cxl_rch.c
> >> PCI/AER: Report CXL or PCIe bus error type in trace logging
> >> cxl/pci: Update RAS handler interfaces to also support CXL Ports
> >> cxl/pci: Log message if RAS registers are unmapped
> >> cxl/pci: Unify CXL trace logging for CXL Endpoints and CXL Ports
> >> cxl/pci: Update cxl_handle_cor_ras() to return early if no RAS errors
> >> cxl/pci: Map CXL Endpoint Port and CXL Switch Port RAS registers
> >> CXL/PCI: Introduce PCI_ERS_RESULT_PANIC
> >> CXL/AER: Introduce pcie/aer_cxl_vh.c in AER driver for forwarding CXL
> >> errors
> >> cxl: Introduce cxl_pci_drv_bound() to check for bound driver
> >> cxl: Change CXL handlers to use guard() instead of scoped_guard()
> >> cxl/pci: Introduce CXL protocol error handlers for Endpoints
> >> CXL/PCI: Introduce CXL Port protocol error handlers
> >> PCI/AER: Dequeue forwarded CXL error
> >> CXL/PCI: Export and rename merge_result() to pci_ers_merge_result()
> >> CXL/PCI: Introduce CXL uncorrectable protocol error recovery
> >> CXL/PCI: Enable CXL protocol errors during CXL Port probe
> >> CXL/PCI: Disable CXL protocol error interrupts during CXL Port cleanup
> > Is the mix of "CXL/PCI" vs "cxl/pci" in the above telling me
> > something, or should they all match?
> >
> > As a rule of thumb, I'm going to look at things that start with "PCI"
> > and skip most of the rest on the assumption that the rest only have
> > incidental effects on PCI.
>
> I think there was logic behind the (un)capitalized but I forget the
> reasoning. It's  better to keep it simple. I'll change to use
> PCI/CXL and AER/CXL.

I don't know what "AER/CXL" means. I think "PCI" and "CXL" are the
big chunks here and one of them should be first in the prefix.

I do think there's value in using "PCI/AER" for things specific to AER
and "PCI/ERR" for more generic PCI error handling, and maybe "PCI/CXL"
for significant CXL-related things in drivers/pci/.