Re: [RESEND v13 08/25] CXL/AER: Move AER drivers RCH error handling into pcie/aer_cxl_rch.c

Lukas Wunner
2025-11-19T08:26:34Z

On Tue, Nov 18, 2025 at 07:20:22PM -0800, dan.j.williams@intel.com wrote:
> > +++ b/drivers/pci/pcie/aer.c
> > @@ -1130,7 +1130,7 @@ static bool find_source_device(struct pci_dev *parent,
> > * Note: AER must be enabled and supported by the device which must be
> > * checked in advance, e.g. with pcie_aer_is_native().
> > */
> > -static void pci_aer_unmask_internal_errors(struct pci_dev *dev)
> > +void pci_aer_unmask_internal_errors(struct pci_dev *dev)
> > {
> > int aer = dev->aer_cap;
> > u32 mask;
> > @@ -1143,116 +1143,25 @@ static void pci_aer_unmask_internal_errors(struct pci_dev *dev)
> > mask &= ~PCI_ERR_COR_INTERNAL;
> > pci_write_config_dword(dev, aer + PCI_ERR_COR_MASK, mask);
> > }
> > +EXPORT_SYMBOL_GPL(pci_aer_unmask_internal_errors);
>
> I can not imagine any other driver but the CXL core consuming this
> symbol, so how about:
>
> EXPORT_SYMBOL_FOR_MODULES(pci_aer_unmask_internal_errors, "cxl_core")

The "xe" driver needs to unmask Uncorrectable Internal Errors
(the default is "masked" per PCIe r7.0 sec 7.8.4.3) and could
take advantage of this helper, so I've asked Terry to keep it
available for anyone to use:

https://lore.kernel.org/all/aK66OcdL4Meb0wFt@wunner.de/

Thanks,

Lukas