Re: [RESEND v13 11/25] cxl/pci: Log message if RAS registers are unmapped

dan.j.williams
2025-11-19T03:27:20Z

Terry Bowman wrote:
> The CXL RAS handlers do not currently log if the RAS registers are
> unmapped. This is needed in order to help debug CXL error handling. Update
> the CXL driver to log a warning message if the RAS register block is
> unmapped during RAS error handling.

That does not tell me anything about why this patch is needed, how this
scenario is entered and why catching this late is ok.

I do not have a problem with the change:

Reviewed-by: Dan Williams <dan.j.williams@intel.com>

...but I would steer away from patches that just say "add debug, because
debug helps debug".

What is more interesting is a story like:

"I lost a bunch of time figuring out why error handling was not working
only to find that in $scenario the RAS registers are not mapped. Save
the next person time by logging this condition".

Otherwise, if I NAK this patch I have no sense that Linux is any worse
off, and fewer patches is a virtue worth considering.