Re: [PATCH v20 06/22] cxl: Move pci generic code

Alejandro Lucero Palau
2025-11-18T14:52:56Z

On 11/17/25 15:00, Dave Jiang wrote:
>
> On 11/15/25 1:12 AM, Alejandro Lucero Palau wrote:
>> On 11/12/25 15:41, Jonathan Cameron wrote:
>>> On Mon, 10 Nov 2025 15:36:41 +0000
>>> alejandro.lucero-palau@amd.com wrote:
>>>
>>>> From: Alejandro Lucero <alucerop@amd.com>
>>>>
>>>> Inside cxl/core/pci.c there are helpers for CXL PCIe initialization
>>>> meanwhile cxl/pci.c implements the functionality for a Type3 device
>>>> initialization.
>>>>
>>>> Move helper functions from cxl/pci.c to cxl/core/pci.c in order to be
>>>> exported and shared with CXL Type2 device initialization.
>>>>
>>>> Fix cxl mock tests affected by the code move, deleting a function which
>>>> indeed was not being used since commit 733b57f262b0("cxl/pci: Early
>>>> setup RCH dport component registers from RCRB").
>>> As I replied late to v19, I'd like to understand more about this comment.
>>> If it was not being used, why can't we remove it before this patch?
>>
>> I replied back then, but if you think this is what I should do with no exception, I'll do it.
>>
>> Should it be part of this patchset or something I should send independently?
> Alison is out this week due to a personal matter. I would just send this ahead and be done with it if it's just a function removal cleanup.

I''l do so today freeing this part from v21 which I want to send tomorrow.

Thank you

> DJ
>
>>
>>>> Signed-off-by: Alejandro Lucero <alucerop@amd.com>
>>>> Reviewed-by: Dave Jiang <dave.jiang@intel.com>
>>>> Reviewed-by: Ben Cheatham <benjamin.cheatham@amd.com>
>>>> Reviewed-by: Fan Ni <fan.ni@samsung.com>
>>>> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>>>> Reviewed-by: Alison Schofield <alison.schofield@intel.com>
>>>> Reviewed-by: Dan Williams <dan.j.williams@intel.com>