Re: [PATCH v4 00/29] lan966x pci device: Add support for SFPs

Rob Herring
2025-11-14T17:48:46Z

On Wed, Oct 15, 2025 at 09:13:47AM +0200, Herve Codina wrote:
> Hi,
>
> This series add support for SFPs ports available on the LAN966x PCI
> device. In order to have the SFPs supported, additional devices are
> needed such as clock controller and I2C.
>
> As a reminder, the LAN966x PCI device driver use a device-tree overlay
> to describe devices available on the PCI board. Adding support for SFPs
> ports consists in adding more devices in the already existing
> device-tree overlay.
>
> With those devices added, the device-tree overlay is more complex and
> some consumer/supplier relationship are needed in order to remove
> devices in correct order when the LAN966x PCI driver is removed.
>
> Those links are typically provided by fw_devlink and we faced some
> issues with fw_devlink and overlays.
>
> This series gives the big picture related to the SFPs support from
> fixing issues to adding new devices. Of course, it can be split if
> needed.
>
> The first part of the series (patch 1, 2 and 3) fixes fw_devlink when it
> is used with overlay. Patches 1 and 3 were previously sent by Saravana
> [0]. I just rebased them on top of v6.18-rc1 and added patch 2 in order
> to take into account feedback received on the series sent by Saravana.
>
> Those modification were not sufficient in our case and so, on top of
> that, patches 4 to 7 fix some more issues related to fw_devlink.
>
> Patches 8 to 13 introduce and use fw_devlink_set_device() in already
> existing code.
>
> Patches 14 and 15 are related also to fw_devlink but specific to PCI and
> the device-tree nodes created during enumeration.
>
> Patches 16, 17 and 18 are related fw_devlink too but specific to I2C
> muxes. Patches purpose is to correctly set a link between an adapter
> supplier and its consumer. Indeed, an i2c mux adapter's parent is not
> the i2c mux supplier but the adapter the i2c mux is connected to. Adding
> a new link between the adapter supplier involved when i2c muxes are used
> avoid a freeze observed during device removal.
>
> Patch 19 adds support for fw_delink on x86. fw_devlink is needed to have
> the consumer/supplier relationship between devices in order to ensure a
> correct device removal order. Adding fw_devlink support for x86 has been
> tried in the past but was reverted [1] because it broke some systems.
> Instead of enabling fw_devlink on *all* x86 system, enable it on *all*
> x86 except on those where it leads to issue.
>
> Patches 20 and 21 allow to build clock and i2c controller used by the
> LAN966x PCI device when the LAN966x PCI device is enabled.
>
> Patches 22 to 26 are specific to the LAN966x. They touch the current
> dtso, split it in dtsi/dtso files, rename the dtso and improve the
> driver to allow easier support for other boards.
>
> The next patch (patch 27) update the LAN966x device-tree overlay itself
> to have the SPF ports and devices they depends on described.
>
> The last two patches (patches 28 and 29) sort the existing drivers in
> the needed driver list available in the Kconfig help and add new drivers
> in this list keep the list up to date with the devices described in the
> device-tree overlay.
>
> We believe some items from the above list can be merged separately, with
> no build dependencies. We expect:
>
> - Patches 1 to 7 to be taken by driver core maintainers
>
> - Patches 8 to 13 to be taken by driver core maintainers
>
> - Patches 14 and 15 to be taken by driver core or PCI maintainers
> (depend on patch 8)
>
> - Patches 16 to 18 to be taken by I2C maintainers
>
> - Patch 19 to be taken by driver core or OF maintainers
>
> - Patch 20 to be taken by clock maintainers
>
> - Patch 21 to be taken by I2C maintainers
>
> - Patches 22 to 29 to be taken by misc maintainers

I don't think this is going to land in 6.19, so I've applied patches 1
and 3.

Rob