From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f171.google.com (mail-oi1-f171.google.com [209.85.167.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B26A318EFE for ; Wed, 7 Jan 2026 15:34:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767800045; cv=none; b=GY6egiiCzC08dWOYC89pW1EKzzJYQUDxA40gfbrJZx47fP/fxvcgCYPKk90n1sa0rZiuaayHHvMLIaWPX94lHnsdqw5hdC2HsXtHZCXYzhZZ2dbIVJPBK3ScvQV4GAhZ9p6Yc/bKMFO4sCWx+zTu36cZUaXqO0jQOEIV8Tzf6Z0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767800045; c=relaxed/simple; bh=PyiR4akbn2AeaAQOQjDM80GGb6TmVA/W+ehpX5bfLv4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=t5bX1kUwsk1NCocQgLvDhDGctHkYRDdVOWmyi8tfc3asT3v++G6JHSxMXf3qSrlaMvM9tczzGHRydlwsGYJ+wuAeClx3ojEAcXj97VZ0bLGzowS3PhJqxeaIapo/kcV2ND2xOu4SFYvawpY4D7oLbRwVggI1RXrh2tEz0Y50R+Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=Groves.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZJhZzofs; arc=none smtp.client-ip=209.85.167.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=Groves.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZJhZzofs" Received: by mail-oi1-f171.google.com with SMTP id 5614622812f47-455a461ab6eso929650b6e.2 for ; Wed, 07 Jan 2026 07:34:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767800042; x=1768404842; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=rU7mq0TXsreClp5X76nq6lsunavYv2TLFlf9O5dybH4=; b=ZJhZzofsdnRTqpnyYlsDKwYBdEOS0/pCw8mia1ef9vH+uS06XmJlIPH9JpZQgCs3Kt ihKbx8+lT3CenybuDOeJD6Az1nsGSSNadf0WQcFok1FPFTjl+nRXr+gWYtJzOPJ3s/KT UmryE8hYvgNMo0q8LYR7SHGOcadrOPeWAo6JPJ5DKJlsvw5oXzP+GF/Zf+htc9TDn0sg LFvzrDGg2mfzMm0TyQxJnfv9Wnw2/J0qVg/A9b4v9LH6w708jzN5EzZLxbEUTnkqg3bs pncLMUaGjHDH9o8bqsMWs/mKZL0e+9hjzRn2l0UmWQbM7jbwSI8rtapRTsKqfSBrdb9L h42w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767800042; x=1768404842; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rU7mq0TXsreClp5X76nq6lsunavYv2TLFlf9O5dybH4=; b=mDPfvgO03oMuImVntA8Cg4djRqGlqXPO/Yqkz9IcIVrRCUhlv7G5o8rLP0kUFbXvsr IFCxsKypApRNCVxck+XB0dbXi+S1CUhTBxlUsSO8mAvL9ukevO1ecft7hB/T/FZJLBgf U6nLZApqEiMAY9+kma8CjlOfomtBWt+QN7kBflhMwGD3orApVWMvqDxSMlp1e8V0Q1OU 2eWR+SkgOsVO0RMR87rByEe9kcybXbgthKATGcENLkX1mXHg2ebnjxYb1CtaQWfNhre7 Y0O2EpsZYkravGz222Cessn0fokEZzPRU+LZR1Z7KG9V9MAAOlAcj++2c6VB7EeRgdFA lA0A== X-Forwarded-Encrypted: i=1; AJvYcCXH1Mcc/lsSgAAJx3Z+vclkvrWXqrHcjEM5Kt6CbMhV4y61xjnsp4vHNS98nIZl8JDmezNSbczt1Y0=@vger.kernel.org X-Gm-Message-State: AOJu0YyqO6Ga1X2iqQ2wWylmY5X/Q1JwA5HcG2vS+OnSmQb/t1Jdda9q L1QSHuqiGcQuznj3cDnQYEhKcXi921os8qr0gyrMAk2pec1IeAYc2iIv X-Gm-Gg: AY/fxX5Z/wPSQKH0lH9Qy3Ev8dKXRYLQCQgoWYRpVcBhrFVtOcI4b0kO4ACh2xyeX8F IiP3BNENP78SAP6vyZonm7HXfHDYr5FGm+oz/GEuR6hYRxzKl2D4bbpB2+eybjIurs2EW11IkPE o2kXkVYhPnB3pYq60sDpe4JLd6oCqRMXuT/0EtRCc9hC7rtJPrBiBMA39IBVQf6/jJjepasysqO Ugx3Z0mCmysMQIqUf7Ac1wWTvAps+dTb+dlMgqDew/p1kMM9yi5FYCR5FXeyk3wBkLa85hmfClz QA4+8sOgtvf/eumzucDM+XbAZ4Qa2EtUU0KdGTkMRDN/7H41VR6LG2NUyGgIIRW1tO4PAyMF2OB aunagKCd+36UUuohbF5O1bcGdy2I9xv2JbdEuS1rnr/ccEIOeQIb012uhDy+9tKGhTDVymsIODz /5PpgOiO3gJN4KiIQ8nxSDC0GC4dHdUxM6UmgI/yNk0ZHjBzPNzf6vayA= X-Google-Smtp-Source: AGHT+IGGuPhuNMGxMH3hMywT/xZMd9I63HO5XzGofyUeNCfHY8A9ec2ffaSkWkYNbPyHpjuffbFtfA== X-Received: by 2002:a05:6808:1188:b0:455:7da6:44d5 with SMTP id 5614622812f47-45a6bdaf691mr1055246b6e.27.1767800041948; Wed, 07 Jan 2026 07:34:01 -0800 (PST) Received: from localhost.localdomain ([2603:8080:1500:3d89:a917:5124:7300:7cef]) by smtp.gmail.com with ESMTPSA id 5614622812f47-45a5e2f1de5sm2398106b6e.22.2026.01.07.07.33.59 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 07 Jan 2026 07:34:01 -0800 (PST) Sender: John Groves From: John Groves X-Google-Original-From: John Groves To: John Groves , Miklos Szeredi , Dan Williams , Bernd Schubert , Alison Schofield Cc: John Groves , Jonathan Corbet , Vishal Verma , Dave Jiang , Matthew Wilcox , Jan Kara , Alexander Viro , David Hildenbrand , Christian Brauner , "Darrick J . Wong" , Randy Dunlap , Jeff Layton , Amir Goldstein , Jonathan Cameron , Stefan Hajnoczi , Joanne Koong , Josef Bacik , Bagas Sanjaya , Chen Linxuan , James Morse , Fuad Tabba , Sean Christopherson , Shivank Garg , Ackerley Tng , Gregory Price , Aravind Ramesh , Ajay Joshi , venkataravis@micron.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org, John Groves Subject: [PATCH V3 07/21] dax: prevent driver unbind while filesystem holds device Date: Wed, 7 Jan 2026 09:33:16 -0600 Message-ID: <20260107153332.64727-8-john@groves.net> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260107153332.64727-1-john@groves.net> References: <20260107153244.64703-1-john@groves.net> <20260107153332.64727-1-john@groves.net> Precedence: bulk X-Mailing-List: linux-cxl@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: John Groves Add custom bind/unbind sysfs attributes for the dax bus that check whether a filesystem has registered as a holder (via fs_dax_get()) before allowing driver unbind. When a filesystem like famfs mounts on a dax device, it registers itself as the holder via dax_holder_ops. Previously, there was no mechanism to prevent driver unbind while the filesystem was mounted, which could cause some havoc. The new unbind_store() checks dax_holder() and returns -EBUSY if a holder is registered, giving userspace proper feedback that the device is in use. To use our custom bind/unbind handlers instead of the default ones, set suppress_bind_attrs=true on all dax drivers during registration. Signed-off-by: John Groves --- drivers/dax/bus.c | 53 +++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 53 insertions(+) diff --git a/drivers/dax/bus.c b/drivers/dax/bus.c index 6e0e28116edc..ed453442739d 100644 --- a/drivers/dax/bus.c +++ b/drivers/dax/bus.c @@ -151,9 +151,61 @@ static ssize_t remove_id_store(struct device_driver *drv, const char *buf, } static DRIVER_ATTR_WO(remove_id); +static const struct bus_type dax_bus_type; + +/* + * Custom bind/unbind handlers for dax bus. + * The unbind handler checks if a filesystem holds the dax device and + * returns -EBUSY if so, preventing driver unbind while in use. + */ +static ssize_t unbind_store(struct device_driver *drv, const char *buf, + size_t count) +{ + struct device *dev; + int rc = -ENODEV; + + dev = bus_find_device_by_name(&dax_bus_type, NULL, buf); + if (dev && dev->driver == drv) { + struct dev_dax *dev_dax = to_dev_dax(dev); + + if (dax_holder(dev_dax->dax_dev)) { + dev_dbg(dev, + "%s: blocking unbind due to active holder\n", + __func__); + rc = -EBUSY; + goto out; + } + device_release_driver(dev); + rc = count; + } +out: + put_device(dev); + return rc; +} +static DRIVER_ATTR_WO(unbind); + +static ssize_t bind_store(struct device_driver *drv, const char *buf, + size_t count) +{ + struct device *dev; + int rc = -ENODEV; + + dev = bus_find_device_by_name(&dax_bus_type, NULL, buf); + if (dev) { + rc = device_driver_attach(drv, dev); + if (!rc) + rc = count; + } + put_device(dev); + return rc; +} +static DRIVER_ATTR_WO(bind); + static struct attribute *dax_drv_attrs[] = { &driver_attr_new_id.attr, &driver_attr_remove_id.attr, + &driver_attr_bind.attr, + &driver_attr_unbind.attr, NULL, }; ATTRIBUTE_GROUPS(dax_drv); @@ -1591,6 +1643,7 @@ int __dax_driver_register(struct dax_device_driver *dax_drv, drv->name = mod_name; drv->mod_name = mod_name; drv->bus = &dax_bus_type; + drv->suppress_bind_attrs = true; return driver_register(drv); } -- 2.49.0