From: Jonathan Cameron <jonathan.cameron@huawei.com>
To: Dave Jiang <dave.jiang@intel.com>
Cc: Li Ming <ming.li@zohomail.com>, <dave@stgolabs.net>,
<alison.schofield@intel.com>, <vishal.l.verma@intel.com>,
<ira.weiny@intel.com>, <dan.j.williams@intel.com>,
<shiju.jose@huawei.com>, <linux-cxl@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] cxl/acpi: Remove cxl_acpi_set_cache_size()
Date: Thu, 15 Jan 2026 17:31:31 +0000 [thread overview]
Message-ID: <20260115173131.0000500b@huawei.com> (raw)
In-Reply-To: <eb8b98b7-1c56-415b-b0d7-a87f7a33701d@intel.com>
On Fri, 9 Jan 2026 08:53:06 -0700
Dave Jiang <dave.jiang@intel.com> wrote:
> On 1/9/26 8:40 AM, Li Ming wrote:
> > cxl_acpi_set_cache_size() returns an error only when the size of the
> > cache range is not matched with the CXL address range. Almost all
> > implementation of setting cache size is in cxl_acpi_set_cache_size(),
> > cxl_setup_extended_linear_size() does nothing except printing a warning
> > in above error case, but cxl_acpi_set_cache_size() also prints a warning
> > at the same time. So can consolidates these two functions into one, keep
> > the function name as cxl_setup_extended_linear_size().
> >
> > Signed-off-by: Li Ming <ming.li@zohomail.com>
>
> Thanks for the cleanup. Should've happened when I moved it from core to acpi.
>
> Reviewed-by: Dave Jiang <dave.jiang@intel.com>
>
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
next prev parent reply other threads:[~2026-01-15 17:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-09 15:40 [PATCH 1/1] cxl/acpi: Remove cxl_acpi_set_cache_size() Li Ming
2026-01-09 15:53 ` Dave Jiang
2026-01-15 17:31 ` Jonathan Cameron [this message]
2026-01-15 17:58 ` Dave Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260115173131.0000500b@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.li@zohomail.com \
--cc=shiju.jose@huawei.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox