From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 563E532D45C for ; Thu, 22 Jan 2026 15:08:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769094492; cv=none; b=mhEAPbQYg9v7p64QsCu2iWLmf6Ib6gyPPVp3i0DTG8P2yIdFf/3cq/tGW0WxQ435GgMCWdrzYfzggUtDsk12Q4h5QwS2y8QHvYE3nO/mBp6v85ECd++5pL/elPCZNakW5uyk8+yTqPtHD683i/TAJrnxeGjIX0LLn2r9M0usyjw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769094492; c=relaxed/simple; bh=sXXf/xC54+Br9F9u40E7CEc1By0ggWyQhwFQ+Tia+JA=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=h+BPb8S4VK07V3A+vJw8I/HUUDeLVlH8uwaRquGIZ3UhUl8E0CLKB3mVAPvaXY5O8nAkBoJhFBspBntcgVg97qzywcXrjMGWG9VXJ6fmjyVttuGtLTZ9ARiNC6YztO2F97ZyLiolohmZk2hHXXblDczCFk7ZD5PR7VP7N/x7+xY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kQMvxu/6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kQMvxu/6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D4031C116C6; Thu, 22 Jan 2026 15:08:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769094491; bh=sXXf/xC54+Br9F9u40E7CEc1By0ggWyQhwFQ+Tia+JA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=kQMvxu/6RDDQqoJctAhstYl+d/hezqeIGuS48rkxYfTqiOKKKIbqdTxJMWEeWegJy tBFLAqI9L1kZZ3V/bQtZ7D5E1OKfRYOcdy3tRB0NrSMz6HvFGkdkHQxYKEHXMwyzIV KnlxDfnksUA36KcRMNVBkMsXV5l2l3/3OJhH3RBVEQgzTONB7uwpjuW1b2wsKAEPwG MRGMMeXcUO8J2/jg+CUosUcTTKPtCu0WvdfpSkFsDebMA0luAb143cFjKw9VdNe/3B 7xDBMirZra9XbovTgIFf/i0jhvnRaXKteCK9p3/1TZ1XiPaokvxRiRoM+n9/peKoi0 klwVJ7ZBfob6A== Received: from localhost ([::1]) by mail.kernel.org with esmtp (Exim 4.99) (envelope-from ) id 1viwI5-000000051Xh-3Zgn; Thu, 22 Jan 2026 16:08:09 +0100 Date: Thu, 22 Jan 2026 16:08:09 +0100 From: Mauro Carvalho Chehab To: Jonathan Cameron via qemu development Cc: Jonathan Cameron , Michael S Tsirkin , Shiju Jose , Igor Mammedov , Cleber Rosa , John Snow , Subject: Re: [PATCH 02/13] scripts/qmp_helper: add missing CXL UEFI GUID Message-ID: <20260122160809.0a3acbb8@localhost> In-Reply-To: <20260122105214.00001cca@huawei.com> References: <20260121122604.00001609@huawei.com> <20260122105214.00001cca@huawei.com> X-Mailer: Claws Mail 4.3.1 (GTK 3.24.51; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-cxl@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thu, 22 Jan 2026 10:52:14 +0000 Jonathan Cameron via qemu development wrote: > On Wed, 21 Jan 2026 16:45:58 +0100 > Mauro Carvalho Chehab wrote: >=20 > > On Wed, Jan 21, 2026 at 12:26:04PM +0000, Jonathan Cameron wrote: =20 > > > On Wed, 21 Jan 2026 12:25:10 +0100 > > > Mauro Carvalho Chehab wrote: > > > =20 > > > > The UEFI 2.11 - N.2.14. CXL Component Events Section states that > > > > XL events are described at CXL specification 3.2: =20 > > > CXL > > > =20 > > > > 8.2.10.2.1 Event Records > > > >=20 > > > > Add the GUIDs defined here to fuzzy logic error injection code. = =20 > > >=20 > > > +CC linux-cxl as more folk there who will be familiar with this > > > stuff. > > >=20 > > > Some of these won't be seen on a host. The same event > > > infrastructure is used for reporting on out of band interfaces > > > and some in band ones, but not ones that will turn up on the > > > mailboxes that firmware will be using to get info. =20 > >=20 > > Good to know, but UEFI 2.11 still mentions all of them as > > possible GUIDs: > >=20 > > https://uefi.org/specs/UEFI/2.11/Apx_N_Common_Platform_Error_Record= .html#cxl-component-events-section > >=20 > > So, the UEFI 2.11 doesn't explicitly state they won't de delivered > > to OSPM. Quite contrary, they're listed as valid values for CPER, > > even if, in practice, they won't. > >=20 > > This is just a small set of variables, that won't bring any major > > impact on the code. So, I prefer to keep them in sync with the spec. > > If they end removing the unused ones, we can update it in the future. > >=20 > > If you want, I can add a note at the next version with your > > comments about them. > > =20 > A note works for me. >=20 > As I understand it CPER records are getting adopted in other specs > so it may make sense to document them, even if they aren't a possibility > via ACPI. >=20 > However I'm not seeing them in the spec link you point at. =20 > All I'm seeing is a cross reference the CXL spec Events Record Format. Heh, true, I got confused with another field. Yet, at CXL spec 3.2, it is said that: 8.2.10.2 Events =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D This section defines the standard event record format that all CXL devices= shall use when reporting events to the host. ... Table 8-55. Common Event Record Format (Sheet 1 of 2) ------ -------- ----------------------------------------------------------= ------------------ Byte Length Description Offset in Bytes ------ -------- ----------------------------------------------------------= ------------------ 00h 10h Event Record Identifier: UUID representing the specific Event Rec= ord format. The following UUIDs are defined in this spec: =E2=80=A2 fbcd0a77-c260-417f-85a9-088b1621eba6 =E2=80=93 General Media = Event Record (see Table 8-57) =E2=80=A2 601dcbb3-9c06-4eab-b8af-4e9bfb5c9624 =E2=80=93 DRAM Event Rec= ord (see Table 8-58) =E2=80=A2 fe927475-dd59-4339-a586-79bab113b774 =E2=80=93 Memory Module = Event Record (see Table 8-59) =E2=80=A2 e71f3a40-2d29-4092-8a39-4d1c966c7c65 - Memory Sparing Event R= ecord (see Table 8-60) =E2=80=A2 77cf9271-9c02-470b-9fe4-bc7b75f2da97 =E2=80=93 Physical Switc= h Event Record (see Table 7-77) =E2=80=A2 40d26425-3396-4c4d-a5da-3d47263af425 =E2=80=93 Virtual Switch= Event Record (see Table 7-78) =E2=80=A2 8dc44363-0c96-4710-b7bf-04bb99534c3f =E2=80=93 MLD Port Event= Record (see Table 7-79) =E2=80=A2 ca95afa7-f183-4018-8c2f-95268e101a2a - Dynamic Capacity Event= Record (see Table 8-62) ------ -------- ----------------------------------------------------------= ------------------ ... So, CXL specs say they'll arrive at the host, and UEFI doesn't tell they can't arrive the OSPM. In any case, it is easier to just pick the entire set with 8 GUIDs and keep the scripts in sync with the specs than filtering what=20 shouldn't belong there and why, with the risk of eventually miss something. I'll append the diff below to the relevant patches on this patchset. Regards, Mauro --- diff --git a/scripts/ghes_decode.py b/scripts/ghes_decode.py index 6c7fdfe84e3a..7bac7dbd6b3a 100644 --- a/scripts/ghes_decode.py +++ b/scripts/ghes_decode.py @@ -935,6 +935,10 @@ class DecodeCXLCompEvent(): """ =20 # GUIDs, as defined at CXL specification 3.2: 8.2.10.2.1 Event Records + # on Table 8-55. Common Event Record Format + # + # Please notice that, in practice, not all those events will be passed + # to OSPM. Some may be handled internally. guids =3D [ ("General Media", "fbcd0a77-c260-417f-85a9-088b1621eb= a6"), ("DRAM", "601dcbb3-9c06-4eab-b8af-4e9bfb5c96= 24"), diff --git a/scripts/qmp_helper.py b/scripts/qmp_helper.py index 32baca17ce10..583f898f04ef 100755 --- a/scripts/qmp_helper.py +++ b/scripts/qmp_helper.py @@ -778,10 +778,14 @@ class cper_guid: [0xA6, 0xA6, 0x88, 0xB7, 0x28, 0xCF, 0x75, 0xD7]) =20 + # CXL GUIDs, as defined at CXL specification 3.2: 8.2.10.2.1 Event Rec= ords + # on Table 8-55. Common Event Record Format + # + # Please notice that, in practice, not all those events will be passed + # to OSPM. Some may be consumed internally CPER_CXL_PROT_ERR =3D guid(0x80B9EFB4, 0x52B5, 0x4DE3, [0xA7, 0x77, 0x68, 0x78, 0x4B, 0x77, 0x10, 0x48]) - CPER_CXL_EVT_GEN_MEDIA =3D guid(0xFBCD0A77, 0xC260, 0x417F, [0x85, 0xA9, 0x08, 0x8B, 0x16, 0x21, 0xEB, 0xA6])