Re: [PATCH v4 06/10] PCI: wire CXL reset prepare/cleanup

Srirangan Madhavan
2026-01-22T02:17:58Z

﻿On 1/21/26, 2:14 PM, "Dave Jiang" <dave.jiang@intel.com <mailto:dave.jiang@intel.com>> wrote:

>> Wire CXL reset preparation and cleanup into the PCI CXL reset path.
>> The flow now validates/offlines regions, performs teardown and cache
>> flushes, then releases the lock on completion or error. This keeps the
>> common reset_prepare flow intact while adding cxl_reset-specific quiesce logic.
>
> Can this be moved to the ->reset_prepare() callback of 'pci_error_handlers' rather than directly wire it into PCI core code? I don't think we want build a
> dependency of cxl core to the PCI core.

I understand the current implementation is not ideal. But I opted not to insert the call into ->reset_prepare() as pci_error_handler would be invoked for all the other reset methods (cxl_bus, FLR, etc).
Would it be okay to include the same reset prepare steps (i.e region teardown, cache flush, etc) in the common reset prepare?

Thank you.