Re: [ndctl PATCH v8 0/7] Add error injection support

Verma, Vishal L
2026-02-10T17:53:03Z

On Fri, 2026-02-06 at 15:50 -0600, Ben Cheatham wrote:
> v8 Changes:
> - Split inject-error command into 'inject-protocol-error', 'inject-media-poison' (Vishal, Alison)
> - Rename 'cxl-clear-error' command to 'cxl-clear-media-poison' (Alison)
> - Documentation rework to reflect new commands
> - Cleaned up a few error prints
> - Updated help messages
> - Change "clear" param of poison_action() to "inj" and reverse usage accordingly
> - Change cxl_memdev_has_poison_injection() to cxl_memdev_has_poison_support()
> - Used in poison_action() (cxl/inject-error.c) to report missing functionality
> more accurately
> - Print usage when '-a' option is missing for media-poison commands
> - Remove checking if '-a' option is empty in poison_action() (no longer needed)
> - Allow clearing poison when 'inject_poison' file is missing in debugfs (and vice versa)
> - Updated cover letter and commit messages

Thanks for the reworks - this looks good to me.
For the series,

Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>