Linux CXL
 help / color / mirror / Atom feed
From: Davidlohr Bueso <dave@stgolabs.net>
To: Gregory Price <gourry@gourry.net>
Cc: linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-team@meta.com, jonathan.cameron@huawei.com,
	dave.jiang@intel.com, alison.schofield@intel.com,
	vishal.l.verma@intel.com, ira.weiny@intel.com,
	dan.j.williams@intel.com
Subject: Re: [PATCH v3] cxl/memdev: fix deadlock in cxl_memdev_autoremove() on attach failure
Date: Wed, 11 Feb 2026 12:59:16 -0800	[thread overview]
Message-ID: <20260211205916.fmmld2ifc62cl42t@offworld> (raw)
In-Reply-To: <20260211192228.2148713-1-gourry@gourry.net>

On Wed, 11 Feb 2026, Gregory Price wrote:

>cxl_memdev_autoremove() takes device_lock(&cxlmd->dev) via guard(device)
>and then calls cxl_memdev_unregister() when the attach callback was
>provided but cxl_mem_probe() failed to bind.
>
>cxl_memdev_unregister() calls
>  cdev_device_del()
>    device_del()
>      bus_remove_device()
>        device_release_driver()
>
>This path is reached when a driver uses the @attach parameter to
>devm_cxl_add_memdev() and the CXL topology fails to enumerate (e.g.
>DVSEC range registers decode outside platform-defined CXL ranges,
>causing the endpoint port probe to fail).
>
>Add cxl_memdev_attach_failed() to set the scope of the check correctly.

I preferred the "if (!cxl_memdev_did_attach())" but the below still
reads nicely.

Reviewed-by: Davidlohr Bueso <dave@stgolabs.net>

  reply	other threads:[~2026-02-11 22:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-11 19:22 [PATCH v3] cxl/memdev: fix deadlock in cxl_memdev_autoremove() on attach failure Gregory Price
2026-02-11 20:59 ` Davidlohr Bueso [this message]
2026-02-13  3:16 ` dan.j.williams
2026-02-13  5:19   ` Gregory Price
2026-02-23 22:33 ` Dave Jiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260211205916.fmmld2ifc62cl42t@offworld \
    --to=dave@stgolabs.net \
    --cc=alison.schofield@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=gourry@gourry.net \
    --cc=ira.weiny@intel.com \
    --cc=jonathan.cameron@huawei.com \
    --cc=kernel-team@meta.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox