From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: qemu-devel@nongnu.org, Davidlohr Bueso <dave@stgolabs.net>,
linuxarm@huawei.com, linux-cxl@vger.kernel.org,
Ravi Shankar <venkataravis@micron.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Markus Armbruster <armbru@redhat.com>,
Michael Roth <michael.roth@amd.com>
Subject: Re: [PATCH qemu v7 1/7] hw/pcie: Support enabling flit mode
Date: Fri, 20 Feb 2026 13:23:00 -0500 [thread overview]
Message-ID: <20260220132238-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20260220131854-mutt-send-email-mst@kernel.org>
On Fri, Feb 20, 2026 at 01:21:12PM -0500, Michael S. Tsirkin wrote:
> On Wed, Feb 04, 2026 at 05:09:29PM +0000, Jonathan Cameron wrote:
>
> ...
>
> > index 85694707e2e4..3c7ecd8c48bc 100644
> > --- a/hw/mem/cxl_type3.c
> > +++ b/hw/mem/cxl_type3.c
> > @@ -405,7 +405,7 @@ static void build_dvsecs(CXLType3Dev *ct3d)
> > dvsec = (uint8_t *)&(CXLDVSECPortFlexBus){
> > .cap = 0x26, /* 68B, IO, Mem, non-MLD */
> > .ctrl = 0x02, /* IO always enabled */
> > - .status = 0x26, /* same as capabilities */
> > + .status = ct3d->flitmode ? 0x6 : 0x26, /* lack of 68B */
>
>
> would be clearer as:
>
> .status = 0x6 /* IO, Mem, non-MLD */ |
> ct3d->flitmode ? 0x0 : 0x20 /* 68B */
(ct3d->flitmode ? 0x0 : 0x20) naturally due to precedence.
>
>
> I picked this patch up, comment fixup can be a patch on top.
>
>
> --
> MST
next prev parent reply other threads:[~2026-02-20 18:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-04 17:09 [PATCH qemu v7 0/7] hw/cxl: Support Back-Invalidate (+ PCIe Flit mode) Jonathan Cameron
2026-02-04 17:09 ` [PATCH qemu v7 1/7] hw/pcie: Support enabling flit mode Jonathan Cameron
2026-02-20 18:21 ` Michael S. Tsirkin
2026-02-20 18:23 ` Michael S. Tsirkin [this message]
2026-02-04 17:09 ` [PATCH qemu v7 2/7] hw/cxl: Refactor component register initialization Jonathan Cameron
2026-02-04 17:09 ` [PATCH qemu v7 3/7] tests/bios-tables-test: Excluded CEDT.cxl for BI restriction relaxation Jonathan Cameron
2026-02-04 17:09 ` [PATCH qemu v7 4/7] hw/cxl: Update CXL Fixed Memory Window ACPI description to include Back Invalidate support Jonathan Cameron
2026-02-04 17:09 ` [PATCH qemu v7 5/7] tests/acpi/cxl: Update CEDT.cxl to allow BI in CFWMS Jonathan Cameron
2026-02-04 17:09 ` [PATCH qemu v7 6/7] hw/cxl: Support type3 HDM-DB Jonathan Cameron
2026-02-04 17:09 ` [PATCH qemu v7 7/7] hw/cxl: Remove register special_ops->read() Jonathan Cameron
2026-02-05 11:50 ` [PATCH qemu v7 0/7] hw/cxl: Support Back-Invalidate (+ PCIe Flit mode) Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260220132238-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=armbru@redhat.com \
--cc=dave@stgolabs.net \
--cc=linux-cxl@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=michael.roth@amd.com \
--cc=qemu-devel@nongnu.org \
--cc=venkataravis@micron.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox