Re: [PATCH v2 2/3] cxl: export internal structs for external Type2 drivers

[Jonathan Cameron <jonathan.cameron@huawei.com>]

On Wed, 25 Feb 2026 12:14:29 +0000
alejandro.lucero-palau@amd.com wrote:

> From: Alejandro Lucero <alucerop@amd.com>
> 
> In preparation for type2 support, move structs and functions a type2
> driver will need to access to into a new shared header file.
> 
> Differentiate between public and private data to be preserved by type2
> drivers.
> 
> Signed-off-by: Alejandro Lucero <alucerop@amd.com>
> Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> Tested-by: Alison Schofield <alison.schofield@intel.com>
> ---
>  drivers/cxl/cxl.h    |  97 +------------------
>  drivers/cxl/cxlmem.h | 114 ----------------------
>  include/cxl/cxl.h    | 226 +++++++++++++++++++++++++++++++++++++++++++
I'm a tiny bit dubious that this has 'yet' reached the state where the copyright
notice in cxl.h is appropriate.  This patch for instance is just code movement
which I'd not consider sufficient.

Meh, it'll be valid in the end!

Trivial follow through from the earlier patch.

Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>

> diff --git a/include/cxl/cxl.h b/include/cxl/cxl.h
> new file mode 100644
> index 000000000000..11f76d61c9f1
> --- /dev/null
> +++ b/include/cxl/cxl.h

> +/**
> + * cxl_dev_state_create - safely create and cast a cxl dev state embedded in a
> + * driver specific struct.
> + *
> + * @parent: device behind the request
> + * @type: CXL device type
> + * @serial: device identification
> + * @dvsec: dvsec capability offset
> + * @drv_struct: driver struct embedding a cxl_dev_state struct
> + * @member: drv_struct member as cxl_dev_state

Follow through from previous...

> + * @mbox: true if mailbox supported
> + *