Re: [PATCH v3 4/4] cxl/pci: Remove redundant cxl_pci_find_port() call

[Jonathan Cameron <jonathan.cameron@huawei.com>]

On Sat, 28 Feb 2026 17:25:49 +0000
alejandro.lucero-palau@amd.com wrote:

> From: Alejandro Lucero <alucerop@amd.com>
Needs to match the sign-off.

git commit --amend --author="Gregory Price <gourry@gourry.net>"
Should fix that up for you.

> 
> Remove the redundant port lookup from cxl_rcrb_get_comp_regs() and use the
> dport parameter directly. The caller has already validated the port is
> non-NULL before invoking this function.

Given the existing caller only does this immediately before the function call,
what the reasoning for dropping this one rather than dropping the one in
cxl_pci_setup_regs() which would have the same effect?  I'm fine with doing
it here, but needs a tiny bit more descriptive text.  With that added and
the author fixed up

Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>


> 
> Signed-off-by: Gregory Price <gourry@gourry.net>
> Reviewed-by: Alejandro Lucero <alucerop@amd.com>
> ---
>  drivers/cxl/core/pci.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/cxl/core/pci.c b/drivers/cxl/core/pci.c
> index c32cc62c501d..d1f487b3d809 100644
> --- a/drivers/cxl/core/pci.c
> +++ b/drivers/cxl/core/pci.c
> @@ -707,11 +707,6 @@ static int cxl_rcrb_get_comp_regs(struct pci_dev *pdev,
>  		.resource = CXL_RESOURCE_NONE,
>  	};
>  
> -	struct cxl_port *port __free(put_cxl_port) =
> -		cxl_pci_find_port(pdev, &dport);
> -	if (!port)
> -		return -EPROBE_DEFER;
> -
>  	component_reg_phys = cxl_rcd_component_reg_phys(&pdev->dev, dport);
>  	if (component_reg_phys == CXL_RESOURCE_NONE)
>  		return -ENXIO;