From: Jonathan Cameron <jonathan.cameron@huawei.com>
To: <shiju.jose@huawei.com>
Cc: <qemu-devel@nongnu.org>, <linux-cxl@vger.kernel.org>,
<mst@redhat.com>, <peter.maydell@linaro.org>, <dave@stgolabs.net>,
<linuxarm@huawei.com>
Subject: Re: [PATCH 2/3] hw/cxl: Add fixes in Post Package Repair (PPR)
Date: Fri, 6 Mar 2026 09:01:17 +0000 [thread overview]
Message-ID: <20260306090117.00001a24@huawei.com> (raw)
In-Reply-To: <20260227223207.972-3-shiju.jose@huawei.com>
On Fri, 27 Feb 2026 22:32:05 +0000
<shiju.jose@huawei.com> wrote:
> From: Shiju Jose <shiju.jose@huawei.com>
>
As for other two patches, try to indicate what sort of bug it is in the title.
Something like:
hw/cxl: Fix failure to remove repaired cachelines from
> Add following fixes to the commit: hw/cxl: Add support for Maintenance
> command and Post Package Repair (PPR).
>
> In cxl_perform_ppr(), remove and free the maintenance entry from QLIST
> if match is found and PPR operation is performed.
Needs a fixes tag.
>
> Signed-off-by: Shiju Jose <shiju.jose@huawei.com>
> ---
> hw/cxl/cxl-mailbox-utils.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/cxl/cxl-mailbox-utils.c b/hw/cxl/cxl-mailbox-utils.c
> index 9c99422cd4..66a58396ee 100644
> --- a/hw/cxl/cxl-mailbox-utils.c
> +++ b/hw/cxl/cxl-mailbox-utils.c
> @@ -2068,6 +2068,8 @@ static void cxl_perform_ppr(CXLType3Dev *ct3d, uint64_t dpa)
> CXL_MEMDEV_MAINT_SUBCLASS_CACHELINE_SPARING,
> ent, NULL);
> }
> + QLIST_REMOVE(ent, node);
> + g_free(ent);
> break;
> }
> }
next prev parent reply other threads:[~2026-03-06 9:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-27 22:32 [PATCH 0/3] hw/cxl: Add fixes in maintenance, PPR and event records shiju.jose
2026-02-27 22:32 ` [PATCH 1/3] hw/cxl: Add fixes in maintenance and memory sparing shiju.jose
2026-03-05 10:57 ` Jonathan Cameron
2026-03-05 15:55 ` Shiju Jose
2026-02-27 22:32 ` [PATCH 2/3] hw/cxl: Add fixes in Post Package Repair (PPR) shiju.jose
2026-03-06 9:01 ` Jonathan Cameron [this message]
2026-02-27 22:32 ` [PATCH 3/3] hw/cxl/events: Fixes for component id in event records generation shiju.jose
2026-03-05 10:59 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260306090117.00001a24@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=dave@stgolabs.net \
--cc=linux-cxl@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=shiju.jose@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox