From: Bjorn Helgaas <helgaas@kernel.org>
To: "Fabio M. De Francesco" <fabio.m.de.francesco@linux.intel.com>
Cc: linux-cxl@vger.kernel.org, Davidlohr Bueso <dave@stgolabs.net>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
Dave Jiang <dave.jiang@intel.com>,
Alison Schofield <alison.schofield@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [RFC PATCH v2] cxl/core: Work around CXL Port PM Init failure when ACS SV enabled
Date: Tue, 17 Mar 2026 10:47:25 -0500 [thread overview]
Message-ID: <20260317154725.GA87339@bhelgaas> (raw)
In-Reply-To: <20260311164145.498207-1-fabio.m.de.francesco@linux.intel.com>
On Wed, Mar 11, 2026 at 05:36:47PM +0100, Fabio M. De Francesco wrote:
> Compute Express Link (CXL) Specification Revision 4.0, Version 1.0, Section
> 8.1.5.1 - CXL Port Extension Status, Implementation Note, describes a
> scenario where a CXL downstream port may fail PM initialization:
> +++ b/include/uapi/linux/pci_regs.h
> @@ -1397,4 +1397,8 @@
> #define PCI_DVSEC_CXL_REG_LOCATOR_BLOCK_ID __GENMASK(15, 8)
> #define PCI_DVSEC_CXL_REG_LOCATOR_BLOCK_OFF_LOW __GENMASK(31, 16)
>
> +/* CXL 4.0 8.1.5.1: CXL Port Extension Status */
> +#define CXL_DVSEC_PORT_EXT_STATUS 0xA
> +#define CXL_DVSEC_PORT_EXT_STATUS_PM_INIT_COMP_MASK GENMASK(1, 0)
Please pay attention to the surrounding definitions. This appears to
belong with the PCI_DVSEC_CXL_PORT above and should match the naming,
capitalization, and whitespace of those definitions.
My copy of CXL r4.0, sec 8.1.5.1, shows Port Power Management
Initialization Complete in the 16-bit CXL Port Extension Status at
offset 0Ah as a single bit, not the two bits from "GENMASK(1, 0)", so
I assume this should be "_BITUL(0)" instead.
prev parent reply other threads:[~2026-03-17 15:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-11 16:36 [RFC PATCH v2] cxl/core: Work around CXL Port PM Init failure when ACS SV enabled Fabio M. De Francesco
2026-03-17 15:47 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260317154725.GA87339@bhelgaas \
--to=helgaas@kernel.org \
--cc=alison.schofield@intel.com \
--cc=bhelgaas@google.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=fabio.m.de.francesco@linux.intel.com \
--cc=ira.weiny@intel.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox