Re: [PATCH V8 3/8] dax: add fsdev.c driver for fs-dax on character dax

Jonathan Cameron
2026-03-23T12:12:55Z

> > > diff --git a/drivers/dax/Makefile b/drivers/dax/Makefile
> > > index 5ed5c39857c8..3bae252fd1bf 100644
> > > --- a/drivers/dax/Makefile
> > > +++ b/drivers/dax/Makefile
> > > @@ -5,10 +5,16 @@ obj-$(CONFIG_DEV_DAX_KMEM) += kmem.o
> > > obj-$(CONFIG_DEV_DAX_PMEM) += dax_pmem.o
> > > obj-$(CONFIG_DEV_DAX_CXL) += dax_cxl.o
> > >
> > > +# fsdev_dax: fs-dax compatible devdax driver (needs DEV_DAX and FS_DAX)
> > > +ifeq ($(CONFIG_FS_DAX),y)
> > > +obj-$(CONFIG_DEV_DAX) += fsdev_dax.o
> > > +endif
> >
> > Why not throw in a new CONFIG_FSDAX_DEV and handle the dependencies
> > in Kconfig?
>
> At one point I had another config parameter, but I'm trying not to
> gratuitously add them. The fsdev driver is pretty small, and including it
> whenever FS_DAX is enabled felt reasonable to me. I'm willing to change it
> if there's a consensus that way.

You can make the build do exactly the same thing with a separate Kconfig
option. Just moves where the dependency tracking is. I'd prefer Kconfig
because that's generally where I'd look for something like this.

Jonathan