Linux CXL
 help / color / mirror / Atom feed
From: Alison Schofield <alison.schofield@intel.com>
To: nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org
Cc: Alison Schofield <alison.schofield@intel.com>
Subject: [ndctl PATCH] test/cxl-sanitize: avoid sanitize submit/wait race
Date: Wed, 29 Apr 2026 19:18:39 -0700	[thread overview]
Message-ID: <20260430021843.3919334-1-alison.schofield@intel.com> (raw)

This test verifies that wait-sanitize blocks for the programmed
timeout after issuing sanitize on an inactive memdev.

The sanitize request is issued in the background and wait-sanitize
is called immediately after. In cxl_test, sanitize completes
asynchronously via delayed work, and the sysfs write does not block.
This creates a race where wait-sanitize may run before sanitize is
observed and return immediately.

This test has been reliable since its introduction, but recently
started failing consistently in one environment, suggesting a
timing sensitivity. It fails here:

  ((SECONDS > start + 2)) || err $LINENO

Add a short delay after backgrounding the sanitize write to make
sure that wait-sanitize can observe the in-progress operation.

A sysfs-based synchronization was considered, but no in-progress
state is exposed to user space.

Signed-off-by: Alison Schofield <alison.schofield@intel.com>
---
 test/cxl-sanitize.sh | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/test/cxl-sanitize.sh b/test/cxl-sanitize.sh
index 9c161014ccb7..d1ed598f3663 100644
--- a/test/cxl-sanitize.sh
+++ b/test/cxl-sanitize.sh
@@ -68,6 +68,9 @@ done
 set_timeout $inactive 3000
 start=$SECONDS
 echo 1 > /sys/bus/cxl/devices/${inactive}/security/sanitize &
+
+# Allow background sanitize to start before wait-sanitize can observe it
+sleep 1
 "$CXL" wait-sanitize $inactive || err $LINENO
 ((SECONDS > start + 2)) || err $LINENO
 
-- 
2.37.3


             reply	other threads:[~2026-04-30  2:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-30  2:18 Alison Schofield [this message]
2026-04-30 16:31 ` [ndctl PATCH] test/cxl-sanitize: avoid sanitize submit/wait race Dave Jiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260430021843.3919334-1-alison.schofield@intel.com \
    --to=alison.schofield@intel.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=nvdimm@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox