Re: [PATCH v30 1/2] cxl: Support Type2 cxl regs mapping

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit claims to export core functions for a Type2 driver to discover and map device registers, but it fails to expose the mapping functions in a public header.
--

commit e264e4eb8d1791f45613794c005249488536d8e2
Author: Alejandro Lucero <alucerop@amd.com>

cxl: Support Type2 cxl regs mapping

This commit creates a new public header file for CXL PCI definitions. It
exports the register setup function and register block identifier enum so
that out-of-subsystem Type2 drivers can discover device registers.

> Export cxl core functions for a Type2 driver being able to discover and
> map the device registers.

[ ... ]

> diff --git a/include/cxl/pci.h b/include/cxl/pci.h
> new file mode 100644
> index 0000000000000..3e0000015871a
> --- /dev/null
> +++ b/include/cxl/pci.h
> @@ -0,0 +1,22 @@

[ ... ]

> +struct cxl_register_map;
> +struct pci_dev;
> +
> +int cxl_pci_setup_regs(struct pci_dev *pdev, enum cxl_regloc_type type,
> +		       struct cxl_register_map *map);
> +#endif

[Severity: Medium]
The commit message mentions exporting functions to both discover and map device
registers, but are the mapping functions missing from this public header?

While cxl_pci_setup_regs() is exposed here for register discovery, the
functions needed to map those registers, cxl_map_component_regs() and
cxl_map_device_regs(), appear to remain unexported in the private
drivers/cxl/cxl.h header.

Does this regression prevent a Type 2 driver outside of drivers/cxl/ from
cleanly calling the mapping functions without duplicating prototypes or
violating subsystem boundaries?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260629183727.51502-1-alejandro.lucero-palau@amd.com?part=1