Re: [PATCH v6 6/6] cxl/test: Add cxl_test accelerator driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The module calls an undefined function `cxl_set_capacity()`, resulting in a build failure.
--

commit 4857e7bc9c7f23612e9f8b197d31f99d7d824ef0
Author: Dave Jiang <dave.jiang@intel.com>

cxl/test: Add cxl_test accelerator driver

This commit adds a mock driver for a platform device that simulates a CXL 
type2 accelerator. It exercises the minimal API calls that a real CXL type2 
driver would use.

> diff --git a/tools/testing/cxl/test/accel.c b/tools/testing/cxl/test/accel.c
> new file mode 100644
> index 0000000000000..8e6f4687ca02a
> --- /dev/null
> +++ b/tools/testing/cxl/test/accel.c
[ ... ]
> +static int cxl_mock_accel_probe(struct platform_device *pdev)
> +{
[ ... ]
> +	cxlds = &cxl_accel->cxlds;
> +	cxlds->media_ready = true;
> +	rc = cxl_set_capacity(cxlds, SZ_512M);

[Severity: Low]
Does cxl_set_capacity() exist in the kernel tree? I am unable to locate a 
declaration or definition for this function, which seems like it would 
trigger a build failure during module compilation.

> +	if (rc)
> +		return rc;
> +
> +	cxlmd = devm_cxl_probe_mem(cxlds, &mock_range);

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260629202720.3658117-1-dave.jiang@intel.com?part=6