From: Shaikh Kamaluddin <shaikhkamal2012@gmail.com>
To: Davidlohr Bueso <dave@stgolabs.net>,
Jonathan Cameron <jic23@kernel.org>,
Dave Jiang <dave.jiang@intel.com>,
Alison Schofield <alison.schofield@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Dan Williams <djbw@kernel.org>, Ira Weiny <iweiny@kernel.org>,
Li Ming <ming.li@zohomail.com>, Robert Richter <rrichter@amd.com>,
Gregory Price <gourry@gourry.net>
Cc: linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] cxl: use %pe to print error pointers
Date: Sat, 1 Aug 2026 15:42:17 +0530 [thread overview]
Message-ID: <20260801101217.12778-1-shaikhkamal2012@gmail.com> (raw)
Make the code printing pointer error values simpler and address the
coccinelle warnings:
drivers/cxl/core/port.c:939:3-10: WARNING: Consider using %pe to print PTR_ERR()
drivers/cxl/core/port.c:1275:25-32: WARNING: Consider using %pe to print PTR_ERR()
drivers/cxl/core/port.c:1309:25-32: WARNING: Consider using %pe to print PTR_ERR()
drivers/cxl/core/region.c:686:3-10: WARNING: Consider using %pe to print PTR_ERR()
drivers/cxl/core/region.c:3778:13-20: WARNING: Consider using %pe to print PTR_ERR()
The %pe specifier prints the error symbolically, so a failed dport
addition reports -EBUSY rather than -16, which is easier to follow
when tracing port and region setup with dynamic debug enabled.
The PTR_ERR() uses in return statements are left unchanged.
Signed-off-by: Shaikh Kamaluddin <shaikhkamal2012@gmail.com>
---
Tested with cxl config build in x86 Architecture
drivers/cxl/core/port.c | 13 ++++++-------
drivers/cxl/core/region.c | 8 ++++----
2 files changed, 10 insertions(+), 11 deletions(-)
diff --git a/drivers/cxl/core/port.c b/drivers/cxl/core/port.c
index 1215ee4f4035..c9875e6af9f6 100644
--- a/drivers/cxl/core/port.c
+++ b/drivers/cxl/core/port.c
@@ -932,11 +932,10 @@ struct cxl_port *devm_cxl_add_port(struct device *host,
parent_port = parent_dport ? parent_dport->port : NULL;
if (IS_ERR(port)) {
- dev_dbg(uport_dev, "Failed to add%s%s%s: %ld\n",
+ dev_dbg(uport_dev, "Failed to add%s%s%s: %pe\n",
parent_port ? " port to " : "",
parent_port ? dev_name(&parent_port->dev) : "",
- parent_port ? "" : " root port",
- PTR_ERR(port));
+ parent_port ? "" : " root port", port);
} else {
dev_dbg(uport_dev, "%s added%s%s%s\n",
dev_name(&port->dev),
@@ -1271,8 +1270,8 @@ struct cxl_dport *devm_cxl_add_dport(struct cxl_port *port,
dport = __devm_cxl_add_dport(port, dport_dev, port_id,
component_reg_phys, CXL_RESOURCE_NONE);
if (IS_ERR(dport)) {
- dev_dbg(dport_dev, "failed to add dport to %s: %ld\n",
- dev_name(&port->dev), PTR_ERR(dport));
+ dev_dbg(dport_dev, "failed to add dport to %s: %pe\n",
+ dev_name(&port->dev), dport);
} else {
dev_dbg(dport_dev, "dport added to %s\n",
dev_name(&port->dev));
@@ -1305,8 +1304,8 @@ struct cxl_dport *devm_cxl_add_rch_dport(struct cxl_port *port,
dport = __devm_cxl_add_dport(port, dport_dev, port_id,
CXL_RESOURCE_NONE, rcrb);
if (IS_ERR(dport)) {
- dev_dbg(dport_dev, "failed to add RCH dport to %s: %ld\n",
- dev_name(&port->dev), PTR_ERR(dport));
+ dev_dbg(dport_dev, "failed to add RCH dport to %s: %pe\n",
+ dev_name(&port->dev), dport);
} else {
dev_dbg(dport_dev, "RCH dport added to %s\n",
dev_name(&port->dev));
diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c
index 1e211542b6b6..894df68a6074 100644
--- a/drivers/cxl/core/region.c
+++ b/drivers/cxl/core/region.c
@@ -682,8 +682,8 @@ static int alloc_hpa(struct cxl_region *cxlr, resource_size_t size)
dev_name(&cxlr->dev));
if (IS_ERR(res)) {
dev_dbg(&cxlr->dev,
- "HPA allocation error (%ld) for size:%pap in %s %pr\n",
- PTR_ERR(res), &size, cxlrd->res->name, cxlrd->res);
+ "HPA allocation error (%pe) for size:%pap in %s %pr\n",
+ res, &size, cxlrd->res->name, cxlrd->res);
return PTR_ERR(res);
}
@@ -3773,9 +3773,9 @@ static struct cxl_region *construct_region(struct cxl_root_decoder *cxlrd,
if (IS_ERR(cxlr)) {
dev_err(cxlmd->dev.parent,
- "%s:%s: %s failed assign region: %ld\n",
+ "%s:%s: %s failed assign region: %pe\n",
dev_name(&cxlmd->dev), dev_name(&cxled->cxld.dev),
- __func__, PTR_ERR(cxlr));
+ __func__, cxlr);
return cxlr;
}
base-commit: f5098b6bae761e346ebcd9da7f95622c04733cff
--
2.43.0
next reply other threads:[~2026-08-01 10:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-01 10:12 Shaikh Kamaluddin [this message]
2026-08-01 17:13 ` [PATCH] cxl: use %pe to print error pointers Alison Schofield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260801101217.12778-1-shaikhkamal2012@gmail.com \
--to=shaikhkamal2012@gmail.com \
--cc=alison.schofield@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=djbw@kernel.org \
--cc=gourry@gourry.net \
--cc=iweiny@kernel.org \
--cc=jic23@kernel.org \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.li@zohomail.com \
--cc=rrichter@amd.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox