Re: [PATCH v11 05/12] cxl: Cache endpoint decoder settings during PCI enumeration

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Mixing goto-based error handling with scope-based cleanup helpers (`scoped_guard`) in `__pci_cxl_hdm_init()`.
--

commit 240aef0efe56885a67760e149786f74d4a709d41
Author: Srirangan Madhavan <smadhavan@nvidia.com>

cxl: Cache endpoint decoder settings during PCI enumeration

This commit populates pci_dev->hdm for CXL.mem functions from
pci_bus_add_device(), after final PCI fixups but before driver binding.
It uses the CXL Register Locator BAR Indicator to find the component
register BAR and reject unassigned or disabled memory BAR resources.

> diff --git a/drivers/cxl/core/resource.c b/drivers/cxl/core/resource.c
> index e6aa55079c76e..a43a29e086501 100644
> --- a/drivers/cxl/core/resource.c
> +++ b/drivers/cxl/core/resource.c
[ ... ]
> +static int __pci_cxl_hdm_init(struct pci_dev *pdev)
> +{
> +	struct cxl_register_map map = { 0 };
> +	struct cxl_hdm_info *info;
> +	int rc;
> +
> +	scoped_guard(rwsem_read, &cxl_rwsem.dpa) {
> +		if (pdev->hdm)
> +			return 0;
> +	}
[ ... ]
> +	info = kzalloc_obj(*info, GFP_KERNEL);
> +	if (!info)
> +		return -ENOMEM;
> +
> +	rc = cxl_pci_hdm_read_info(pdev, &map, info);
> +	if (rc)
> +		goto out_free_info;
> +
> +	scoped_guard(rwsem_write, &cxl_rwsem.dpa) {
> +		if (!pdev->hdm) {
> +			pdev->hdm = info;
> +			info = NULL;
> +		} else {
> +			cxl_pci_hdm_info_free(info);
> +		}
> +	}
> +
> +	return 0;
> +
> +out_free_info:
> +	cxl_pci_hdm_info_free(info);
> +	return rc;
> +}

[Severity: Low]
Does this code violate the cleanup API guidelines by mixing goto-based error
handling with scope-based cleanup helpers (scoped_guard) in
__pci_cxl_hdm_init()?

The expectation in include/linux/cleanup.h is that goto and cleanup helpers
are never mixed in the same function. Could this be converted to use
scope-based cleanup for the info allocation as well, to avoid confusing
ownership and maintenance hazards in the future?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260902072804.665639-1-smadhavan@nvidia.com?part=5