Re: [PATCH RFC 05/11] mm/migrate: add a dedicated movable_ops migration pass

[sashiko-bot@kernel.org]

> Pages with movable_ops transfer ownership through a driver callback and do
> not need the unmap, TLB flush, copy, or LRU handling used for LRU folios.
> These pages are expected to stop being represented as folios. Separating
> their migration from the LRU folio path prepares for that conversion.
> 
> Add migrate_movable_ops_pages() before LRU folio migration to handle
> allocation, locking, retries, and cleanup on a separate list. Return
> remaining pages through @ret_folios and remove the now-unreachable
> movable_ops branches from the LRU path.
> 
> This changes three details of movable_ops migration:
>  - Pages are processed before LRU folios rather than in source-list order.
>  - Synchronous callers use the requested mode from the first attempt
>    instead of the LRU asynchronous pre-pass.
>  - A callback returning -EAGAIN ends the current attempt, so a later
>    retry allocates a fresh destination.
>  - MIGRATE_SYNC_LIGHT waits for the page lock instead of giving up,
>    because !uptodate check is not applicable for movable_ops
>    pages.
> 
> Suggested-by: Zi Yan <ziy@nvidia.com>
> Suggested-by: David Hildenbrand (Arm) <david@kernel.org>
> Signed-off-by: Shivank Garg <shivankg@amd.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260902-migrate-refactor-shivank-v1-0-9dcca87669c4@amd.com?part=5