From: <alucerop@amd.com>
To: <linux-cxl@vger.kernel.org>, <netdev@vger.kernel.org>
Cc: <davem@davemloft.net>, <kuba@kernel.org>, <pabeni@redhat.com>,
<edumazet@google.com>, <ecree.xilinx@gmail.com>,
<icheng@nvidia.com>, <rafael@kernel.org>,
Alejandro Lucero <alucerop@amd.com>
Subject: [PATCH v1 1/4] driver core: Rely on supplier driver binding at link creation
Date: Mon, 21 Sep 2026 20:12:36 +0100 [thread overview]
Message-ID: <20260921191239.4249-2-alucerop@amd.com> (raw)
In-Reply-To: <20260921191239.4249-1-alucerop@amd.com>
From: Alejandro Lucero <alucerop@amd.com>
Differentiate between driver binding from PM dependency when a device
link is created. Rely on the device being bound to a driver for validating
the supplier as some device drivers could not support PM.
Check for supplier's PM state only if consumer specifies PM_RUNTIME flag.
Signed-off-by: Alejandro Lucero <alucerop@amd.com>
---
drivers/base/core.c | 27 +++++++++++++++++++--------
1 file changed, 19 insertions(+), 8 deletions(-)
diff --git a/drivers/base/core.c b/drivers/base/core.c
index 4c0c373998a1..eb6d87e35d76 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -834,15 +834,26 @@ struct device_link *device_link_add(struct device *consumer,
device_pm_lock();
/*
- * If the supplier has not been fully registered yet or there is a
- * reverse (non-SYNC_STATE_ONLY) dependency between the consumer and
- * the supplier already in the graph, return NULL. If the link is a
- * SYNC_STATE_ONLY link, we don't check for reverse dependencies
- * because it only affects sync_state() callbacks.
+ * If the supplier has not been fully registered yet with a driver
+ * return NULL.
*/
- if (!device_pm_initialized(supplier)
- || (!(flags & DL_FLAG_SYNC_STATE_ONLY) &&
- device_is_dependent(consumer, supplier))) {
+ scoped_guard(device, supplier) {
+ if (!device_is_bound(supplier)) {
+ link = NULL;
+ goto out;
+ }
+ }
+ /*
+ * If consumer asks for PM to use the link and the supplier has not
+ * PM initialized, or if there is a reverse (non-SYNC_STATE_ONLY)
+ * dependency between the consumer and the supplier already in the
+ * graph, return NULL. If the link is a SYNC_STATE_ONLY link, we
+ * don't check for reverse dependencies because it only affects
+ * sync_state() callbacks.
+ */
+ if (((flags & DL_FLAG_PM_RUNTIME) && !device_pm_initialized(supplier)) ||
+ (!(flags & DL_FLAG_SYNC_STATE_ONLY) &&
+ device_is_dependent(consumer, supplier))) {
link = NULL;
goto out;
}
--
2.34.1
next prev parent reply other threads:[~2026-09-21 17:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 19:12 [PATCH v1 0/4] Type2 multipf support alucerop
2026-09-21 19:12 ` alucerop [this message]
2026-09-22 17:56 ` [PATCH v1 1/4] driver core: Rely on supplier driver binding at link creation sashiko-bot
2026-09-22 21:39 ` Maxime Chevallier
2026-09-23 8:49 ` Lucero Palau, Alejandro
2026-09-23 9:58 ` Lucero Palau, Alejandro
2026-09-24 8:59 ` Lucero Palau, Alejandro
2026-09-21 19:12 ` [PATCH v1 2/4] cxl/region: Add region reference in memdev attach alucerop
2026-09-22 17:56 ` sashiko-bot
2026-09-21 19:12 ` [PATCH v1 3/4] cxl/memdev: Add support for multi PF devices alucerop
2026-09-21 23:07 ` Dave Jiang
2026-09-22 14:07 ` Lucero Palau, Alejandro
2026-09-22 16:39 ` Dave Jiang
2026-09-22 17:56 ` sashiko-bot
2026-09-21 19:12 ` [PATCH v1 4/4] sfc: add multipf support alucerop
2026-09-22 17:56 ` sashiko-bot
2026-09-24 1:15 ` Jonathan Cameron
2026-09-25 11:16 ` Lucero Palau, Alejandro
2026-09-25 20:24 ` Jonathan Cameron
2026-09-23 20:00 ` [syzbot ci] Re: Type2 " syzbot ci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260921191239.4249-2-alucerop@amd.com \
--to=alucerop@amd.com \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=icheng@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-cxl@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox