Linux CXL
 help / color / mirror / Atom feed
From: Junjie Cao <junjie.cao@linux.dev>
To: mjt@tls.msk.ru
Cc: qemu-devel@nongnu.org, qemu-stable@nongnu.org, jic23@kernel.org,
	philmd@oss.qualcomm.com, linux-cxl@vger.kernel.org,
	junjie.cao@linux.dev
Subject: Re: [PATCH v3 0/7] hw/cxl: fix Type-3 device reset resource leaks and convert to three-phase
Date: Fri, 30 Oct 2026 07:44:31 -0500	[thread overview]
Message-ID: <20261030124431.1066454-1-junjie.cao@linux.dev> (raw)
In-Reply-To: <379a2300-b1af-4b32-9d10-7a8347c22476@tls.msk.ru>

Hi Michael,

On 30/10/26 14:35, Michael Tokarev wrote:
> This patch series has been Cc'ed to qemu-stable@.  It is interesting how
> it's been Cc'ed, and I think there's some error here.  From whole series,
> only patch 2 (destroy primary CCI before re-initialization on reset) is
> tagged for-stable.  Patch 1, which is a fix, is not tagged, and not Cc'ed
> to qemu-stable@ either.  The rest - patches 3-7 - has been Cc'ed to the
> qemu-stable mailing list, but are not tagged for-stable.

Thanks for pointing this out. Only patches 1 and 2 were intended
for stable; I copied qemu-stable@ on the whole series. I'll keep
the stable Cc limited to the relevant patches in future.

Patch 1 carries the tag both on the list and in 259b877eac, and you
already have it as 4a39c7d61e in 11.1.2.  So for 11.1.x patch 2 is
indeed the only one left.

> From this list, I'm only picking up patch 2, and only for 11.1.x series.
> The other active stable series, 10.0.x, - apparently it's not needed there.

Neither applies to 10.0 as-is since cxl_destroy_cci() only exists from
10.1, but the leak is there too: ct3d_reset() re-runs cxl_init_cci() on
all three CCIs, allocating a new timer each time.  I've just sent a
10.0 version, "[PATCH stable-10.0] hw/cxl: free the CCI background
timer on Type-3 reset and exit".

Thanks,
Junjie

      reply	other threads:[~2026-10-30 12:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-29 14:46 [PATCH v3 0/7] hw/cxl: fix Type-3 device reset resource leaks and convert to three-phase Junjie Cao
2026-07-29 14:46 ` [PATCH v3 1/7] hw/cxl: fix timer leak in cxl_destroy_cci() Junjie Cao
2026-07-29 14:46 ` [PATCH v3 2/7] hw/cxl: destroy primary CCI before re-initialization on reset Junjie Cao
2026-07-29 14:46 ` [PATCH v3 3/7] hw/cxl: convert cxl-type3 to three-phase reset Junjie Cao
2026-07-29 14:46 ` [PATCH v3 4/7] hw/cxl: add cxl_destroy_mailbox_t3() as the mailbox teardown counterpart Junjie Cao
2026-08-31 10:08   ` Philippe Mathieu-Daudé
2026-07-29 14:46 ` [PATCH v3 5/7] hw/cxl: discard in-flight sanitize state on mailbox teardown Junjie Cao
2026-07-29 14:46 ` [PATCH v3 6/7] hw/cxl: clear event logs, scan media and interrupt policy on reset Junjie Cao
2026-07-29 14:46 ` [PATCH v3 7/7] hw/cxl: clear poison lists and feature transfer state " Junjie Cao
2026-08-31  8:08 ` [PATCH v3 0/7] hw/cxl: fix Type-3 device reset resource leaks and convert to three-phase Junjie Cao
2026-10-30  6:35 ` Michael Tokarev
2026-10-30 12:44   ` Junjie Cao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261030124431.1066454-1-junjie.cao@linux.dev \
    --to=junjie.cao@linux.dev \
    --cc=jic23@kernel.org \
    --cc=linux-cxl@vger.kernel.org \
    --cc=mjt@tls.msk.ru \
    --cc=philmd@oss.qualcomm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox