Linux CXL
 help / color / mirror / Atom feed
From: Alison Schofield <alison.schofield@intel.com>
To: nvdimm@lists.linux.dev
Cc: Alison Schofield <alison.schofield@intel.com>,
	linux-cxl@vger.kernel.org, Dave Jiang <dave.jiang@intel.com>
Subject: [ndctl PATCH] test/cxl-destroy-region.sh: create RAM regions explicitly
Date: Thu,  5 Nov 2026 17:48:46 -0800	[thread overview]
Message-ID: <20261106014848.938714-1-alison.schofield@intel.com> (raw)

The test creates regions it expects to be RAM without passing a type.
create-region defaults to pmem when the root decoder supports both RAM
and PMEM, so the test fails when it picks such a decoder.

cxl_test has one such decoder. Whether the test picks it depends on the
memdev order, which changes when other CXL devices, such as QEMU-emulated
ones, are present.

Use the '-t ram' option so both checks create RAM regions regardless of
which decoder is selected.

This issue appeared while the CXL kernel patch[1] was being tested. It
changes the cxl_test created x1 volatile window to one that support both
RAM and PMEM.

[1] https://lore.kernel.org/linux-cxl/89e8d2cfde4f1054f37a4f48f2b206a7f05108f7.1793850480.git.alison.schofield@intel.com/


Reported-by: Dave Jiang <dave.jiang@intel.com>
Signed-off-by: Alison Schofield <alison.schofield@intel.com>
---
 test/cxl-destroy-region.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/test/cxl-destroy-region.sh b/test/cxl-destroy-region.sh
index 5c3395e530b0..b07589fbbe39 100644
--- a/test/cxl-destroy-region.sh
+++ b/test/cxl-destroy-region.sh
@@ -60,7 +60,7 @@ check_destroy_ram()
 	mem=$1
 	decoder=$2
 
-	region="$("$CXL" create-region -d "$decoder" -m "$mem" | jq -r ".region")"
+	region="$("$CXL" create-region -t ram -d "$decoder" -m "$mem" | jq -r ".region")"
 	if [[ ! $region ]]; then
 		err "$LINENO"
 	fi
@@ -76,7 +76,7 @@ check_destroy_devdax()
 	mem=$1
 	decoder=$2
 
-	region="$("$CXL" create-region -d "$decoder" -m "$mem" | jq -r ".region")"
+	region="$("$CXL" create-region -t ram -d "$decoder" -m "$mem" | jq -r ".region")"
 	if [[ ! $region ]]; then
 		err "$LINENO"
 	fi
-- 
2.37.3


             reply	other threads:[~2026-11-06  1:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-06  1:48 Alison Schofield [this message]
2026-11-06  5:37 ` [ndctl PATCH] test/cxl-destroy-region.sh: create RAM regions explicitly Li Ming
2026-11-06 15:11 ` Dave Jiang
2026-11-06 17:47 ` Alison Schofield

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261106014848.938714-1-alison.schofield@intel.com \
    --to=alison.schofield@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=nvdimm@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox