From: Dave Jiang <dave.jiang@intel.com>
To: alison.schofield@intel.com, Davidlohr Bueso <dave@stgolabs.net>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
Dan Williams <dan.j.williams@intel.com>
Cc: linux-cxl@vger.kernel.org, Li Zhijian <lizhijian@fujitsu.com>
Subject: Re: [PATCH v2] cxl/test: Define a CFMWS capable of a 3 way HB interleave
Date: Thu, 27 Feb 2025 12:24:45 -0700 [thread overview]
Message-ID: <2c4ccd08-1e8c-46f3-9f3b-eb13648f02cf@intel.com> (raw)
In-Reply-To: <20250226221931.2352061-1-alison.schofield@intel.com>
On 2/26/25 3:19 PM, alison.schofield@intel.com wrote:
> From: Alison Schofield <alison.schofield@intel.com>
>
> The CXL unit test cxl-xor-region.sh is skipping a 1+1+1 region
> interleave test case because the window is not defined.
>
> Additionally, upcoming expansion of 3 way HB interleave test cases
> (like 2+2+2) require the same window.
>
> Replace an unused CFMWS with a 3-way capable CFMWS in the set of
> CFMWS's loaded when interleave_arithmetic=1.
>
> Signed-off-by: Alison Schofield <alison.schofield@intel.com>
> Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> Reviewed-by: Ira Weiny <ira.weiny@intel.com>
> Tested-by: Li Zhijian <lizhijian@fujitsu.com>
Applied to cxl/next
> ---
>
> v2: Adjust target list length (Ira)
>
> tools/testing/cxl/test/cxl.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/tools/testing/cxl/test/cxl.c b/tools/testing/cxl/test/cxl.c
> index 083a66a52731..1c3336095923 100644
> --- a/tools/testing/cxl/test/cxl.c
> +++ b/tools/testing/cxl/test/cxl.c
> @@ -155,7 +155,7 @@ static struct {
> } cfmws7;
> struct {
> struct acpi_cedt_cfmws cfmws;
> - u32 target[4];
> + u32 target[3];
> } cfmws8;
> struct {
> struct acpi_cedt_cxims cxims;
> @@ -331,14 +331,14 @@ static struct {
> .length = sizeof(mock_cedt.cfmws8),
> },
> .interleave_arithmetic = ACPI_CEDT_CFMWS_ARITHMETIC_XOR,
> - .interleave_ways = 2,
> - .granularity = 0,
> + .interleave_ways = 8,
> + .granularity = 1,
> .restrictions = ACPI_CEDT_CFMWS_RESTRICT_TYPE3 |
> ACPI_CEDT_CFMWS_RESTRICT_PMEM,
> .qtg_id = FAKE_QTG_ID,
> - .window_size = SZ_256M * 16UL,
> + .window_size = SZ_512M * 6UL,
> },
> - .target = { 0, 1, 0, 1, },
> + .target = { 0, 1, 2, },
> },
> .cxims0 = {
> .cxims = {
>
> base-commit: 2bb67004903cfd35710750654669a77e7223fcd1
prev parent reply other threads:[~2025-02-27 19:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-26 22:19 [PATCH v2] cxl/test: Define a CFMWS capable of a 3 way HB interleave alison.schofield
2025-02-27 19:24 ` Dave Jiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c4ccd08-1e8c-46f3-9f3b-eb13648f02cf@intel.com \
--to=dave.jiang@intel.com \
--cc=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave@stgolabs.net \
--cc=ira.weiny@intel.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-cxl@vger.kernel.org \
--cc=lizhijian@fujitsu.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox