Re: [PATCH ndctl] ndctl.spec.in: Add build dependencies for libtraceevent and libtracefs

[Dave Jiang <dave.jiang@intel.com>]

On 2/22/23 1:20 PM, Vishal Verma wrote:
> The cxl-monitor additions pull in new dependencies on libtraceevent and
> libtracefs. While the commits below added these to the meson build
> system, they neglected to also update the RPM spec file. Add them to
> the spec.
> 
> Fixes: 8dedc6cf5e85 ("cxl: add a helper to parse trace events into a json object")
> Fixes: 7b237bc7a8ae ("cxl: add a helper to go through all current events and parse them")
> Cc: Dave Jiang <dave.jiang@intel.com>
> Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>

Reviewed-by: Dave Jiang <dave.jiang@intel.com>


> ---
>   ndctl.spec.in | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/ndctl.spec.in b/ndctl.spec.in
> index 35c63e6..0543c48 100644
> --- a/ndctl.spec.in
> +++ b/ndctl.spec.in
> @@ -31,6 +31,8 @@ BuildRequires:	keyutils-libs-devel
>   BuildRequires:	systemd-rpm-macros
>   BuildRequires:	iniparser-devel
>   BuildRequires:	meson
> +BuildRequires:	libtraceevent-devel
> +BuildRequires:	libtracefs-devel
>   
>   %description
>   Utility library for managing the "libnvdimm" subsystem.  The "libnvdimm"
> 
> ---
> base-commit: 835b09602cdcae8d324eeaf5bb4f17ae959c5e6d
> change-id: 20230222-fix-rpm-spec-2edf5a7fc25b
> 
> Best regards,