From: "Nelson, Shannon" <shannon.nelson@amd.com>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: Dan Carpenter <dan.carpenter@linaro.org>,
andrew.gospodarek@broadcom.com, aron.silverton@oracle.com,
dan.j.williams@intel.com, daniel.vetter@ffwll.ch,
dave.jiang@intel.com, dsahern@kernel.org,
gregkh@linuxfoundation.org, hch@infradead.org,
itayavr@nvidia.com, jiri@nvidia.com, Jonathan.Cameron@huawei.com,
kuba@kernel.org, lbloch@nvidia.com, leonro@nvidia.com,
linux-cxl@vger.kernel.org, linux-rdma@vger.kernel.org,
netdev@vger.kernel.org, saeedm@nvidia.com, brett.creeley@amd.com
Subject: Re: [PATCH v4 5/6] pds_fwctl: add rpc and query support
Date: Fri, 21 Mar 2025 17:37:08 -0700 [thread overview]
Message-ID: <35b5e5ad-ffec-46fb-a864-89313a4f5120@amd.com> (raw)
In-Reply-To: <20250321235026.GD206770@nvidia.com>
On 3/21/2025 4:50 PM, Jason Gunthorpe wrote:
> On Fri, Mar 21, 2025 at 09:59:32AM -0700, Nelson, Shannon wrote:
>> diff --git a/drivers/fwctl/pds/main.c b/drivers/fwctl/pds/main.c
>> index 6fedde2a962e..e50e1bbdff9a 100644
>> --- a/drivers/fwctl/pds/main.c
>> +++ b/drivers/fwctl/pds/main.c
>> @@ -76,8 +76,7 @@ static int pdsfc_identify(struct pdsfc_dev *pdsfc)
>> int err;
>>
>> ident = dma_alloc_coherent(dev->parent, sizeof(*ident), &ident_pa, GFP_KERNEL);
>> - err = dma_mapping_error(dev->parent, ident_pa);
>> - if (err) {
>> + if (!ident) {
>> dev_err(dev, "Failed to map ident buffer\n");
>> return err;
> x
> err is uninitialized, it should just be -ENOMEM I think.
>
> Anyhow I fixed it up, please let me know
I see them - works for me.
Thanks,
sln
next prev parent reply other threads:[~2025-03-22 0:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-19 21:32 [PATCH v4 0/6] pds_fwctl: fwctl for AMD/Pensando core devices Shannon Nelson
2025-03-19 21:32 ` [PATCH v4 1/6] pds_core: make pdsc_auxbus_dev_del() void Shannon Nelson
2025-03-19 21:32 ` [PATCH v4 2/6] pds_core: specify auxiliary_device to be created Shannon Nelson
2025-03-19 21:32 ` [PATCH v4 3/6] pds_core: add new fwctl auxiliary_device Shannon Nelson
2025-03-19 21:32 ` [PATCH v4 4/6] pds_fwctl: initial driver framework Shannon Nelson
2025-03-19 21:32 ` [PATCH v4 5/6] pds_fwctl: add rpc and query support Shannon Nelson
2025-03-21 14:33 ` Dan Carpenter
2025-03-21 16:59 ` Nelson, Shannon
2025-03-21 23:50 ` Jason Gunthorpe
2025-03-22 0:37 ` Nelson, Shannon [this message]
2025-03-19 21:32 ` [PATCH v4 6/6] pds_fwctl: add Documentation entries Shannon Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35b5e5ad-ffec-46fb-a864-89313a4f5120@amd.com \
--to=shannon.nelson@amd.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=andrew.gospodarek@broadcom.com \
--cc=aron.silverton@oracle.com \
--cc=brett.creeley@amd.com \
--cc=dan.carpenter@linaro.org \
--cc=dan.j.williams@intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dave.jiang@intel.com \
--cc=dsahern@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=itayavr@nvidia.com \
--cc=jgg@nvidia.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=lbloch@nvidia.com \
--cc=leonro@nvidia.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox