RE: [PATCH qemu v4 3/5] hw/cxl/events: Updates for rev3.2 general media event record

[Shiju Jose <shiju.jose@huawei.com>]

>-----Original Message-----
>From: Ravi Jonnalagadda <ravis.opensrc@gmail.com>
>Sent: 04 February 2026 21:42
>To: Jonathan Cameron <jonathan.cameron@huawei.com>
>Cc: Michael Tsirkin <mst@redhat.com>; qemu-devel@nongnu.org; Shiju Jose
><shiju.jose@huawei.com>; armbru@redhat.com; Linuxarm
><linuxarm@huawei.com>; linux-cxl@vger.kernel.org; Ravi Shankar
><venkataravis@micron.com>
>Subject: Re: [PATCH qemu v4 3/5] hw/cxl/events: Updates for rev3.2 general
>media event record
>
>On Mon, Jan 19, 2026 at 3:21 AM Jonathan Cameron
><Jonathan.Cameron@huawei.com> wrote:
>>
>> From: Shiju Jose <shiju.jose@huawei.com>
>>
>> CXL spec rev3.2 section 8.2.10.2.1.1 Table 8-57, general media event
>> table has updated with following new fields.
>> 1. Advanced Programmable Corrected Memory Error Threshold Event Flags
>> 2. Corrected Memory Error Count at Event 3. Memory Event Sub-Type 4.
>> Support for component ID in the PLDM format.
>>
>> Add updates for the above spec changes in the CXL general media event
>> reporting and QMP command to inject general media event.
>>
>> In order to have one consistent source of references, update all to
>> references for this command to CXL r3.2.
>>
>> Signed-off-by: Shiju Jose <shiju.jose@huawei.com>
>> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>> ---
>> v4: Update the spec reference in the related command to 3.2 as well.
>> (Markus)
>> v3: Update all references to 3.2 for consistency.
>> ---
>>  qapi/cxl.json               | 29 +++++++++++++++++++++--------
>>  include/hw/cxl/cxl_events.h |  7 +++++--
>>  hw/mem/cxl_type3.c          | 29 +++++++++++++++++++++++++++++
>>  hw/mem/cxl_type3_stubs.c    |  6 ++++++
>>  4 files changed, 61 insertions(+), 10 deletions(-)
>>
>> diff --git a/qapi/cxl.json b/qapi/cxl.json index
>> 82001c0591d8..4ff66fc6c16c 100644
>> --- a/qapi/cxl.json
>> +++ b/qapi/cxl.json
>>
>>      stw_le_p(&gem.validity_flags, valid_flags);
>>
>> +    if (has_cme_ev_flags) {
>> +        gem.cme_ev_flags = cme_ev_flags;
>> +    } else {
>> +        gem.cme_ev_flags = 0;
>> +    }
>> +
>> +    if (has_cme_count) {
>> +        descriptor |= CXL_GMER_EV_DESC_THRESHOLD_EVENT;
>
>The modification to 'descriptor' here is not written back to gem.descriptor which
>was assigned earlier in this function.
>
>Suggest moving gem.descriptor assignment after this block, similar to how
>valid_flags is handled in this same function.
>
Thanks Ravi.
Will  fix.

>>  void qmp_cxl_inject_dram_event(const char *path, CxlEventLog log,
>> --
>> 2.48.1
>>
>>

Thanks,
Shiju