From: Markus Elfring <Markus.Elfring@web.de>
To: Li Zhijian <lizhijian@fujitsu.com>,
linux-cxl@vger.kernel.org, kernel-janitors@vger.kernel.org,
Alison Schofield <alison.schofield@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
Davidlohr Bueso <dave@stgolabs.net>,
Ira Weiny <ira.weiny@intel.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Vishal Verma <vishal.l.verma@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cxl/region: Fix cxlr_pmem leaks
Date: Wed, 1 May 2024 21:23:12 +0200 [thread overview]
Message-ID: <44d81ab4-e3e8-4552-ba0c-209adb53aa21@web.de> (raw)
In-Reply-To: <20240428030748.318985-1-lizhijian@fujitsu.com>
> Before this error path, cxlr_pmem pointed to a kzalloc() memory, free
> it to avoid this memory leaking.
Can the following wording be a bit nicer?
The local variable “cxlr_pmem” referred to dynamically allocated memory.
Free it in one error case before it is reset to an error pointer.
Would the summary phrase “Fix a memory leak in cxl_pmem_region_alloc()”
be more appropriate here?
Regards,
Markus
prev parent reply other threads:[~2024-05-01 19:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-28 3:07 [PATCH] cxl/region: Fix cxlr_pmem leaks Li Zhijian
2024-04-30 16:45 ` Jonathan Cameron
2024-04-30 19:58 ` Dan Williams
2024-04-30 22:55 ` fan
2024-05-01 19:23 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44d81ab4-e3e8-4552-ba0c-209adb53aa21@web.de \
--to=markus.elfring@web.de \
--cc=Jonathan.Cameron@huawei.com \
--cc=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=ira.weiny@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizhijian@fujitsu.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox