From: "Huang, Kai" <kai.huang@intel.com>
To: "Schofield, Alison" <alison.schofield@intel.com>,
"gourry@gourry.net" <gourry@gourry.net>
Cc: "nunodasneves@linux.microsoft.com"
<nunodasneves@linux.microsoft.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"rafael@kernel.org" <rafael@kernel.org>,
"thorsten.blum@linux.dev" <thorsten.blum@linux.dev>,
"wangyuquan1236@phytium.com.cn" <wangyuquan1236@phytium.com.cn>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Williams, Dan J" <dan.j.williams@intel.com>,
"lenb@kernel.org" <lenb@kernel.org>,
"xueshuai@linux.alibaba.com" <xueshuai@linux.alibaba.com>,
"linux-cxl@vger.kernel.org" <linux-cxl@vger.kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH] ACPI: NUMA: Only parse CFMWS at boot when CXL_ACPI is on
Date: Thu, 5 Mar 2026 00:14:52 +0000 [thread overview]
Message-ID: <4809035f61dcd6ace773532efe46b0f1928be313.camel@intel.com> (raw)
In-Reply-To: <aajGuOC-G_dFYpwa@gourry-fedora-PF4VCD3F>
On Wed, 2026-03-04 at 18:56 -0500, Gregory Price wrote:
> On Wed, Mar 04, 2026 at 03:20:11PM -0800, Alison Schofield wrote:
> > On Wed, Mar 04, 2026 at 05:33:26PM -0500, Gregory Price wrote:
> > > On Thu, Mar 05, 2026 at 10:33:42AM +1300, Kai Huang wrote:
> > > > Increasing the 'nr_node_ids' has side effects. For instance, it is
> > > > widely used by the kernel for "highest possible NUMA node" based memory
> > > > allocations. It also impacts userspace ABIs, e.g., some NUMA memory
> > > > related system calls such as 'get_mempolicy' which requires 'maxnode'
> > > > not being smaller than the 'nr_node_ids'.
> > > >
> >
> > >
> > > Is this a Linux issue or a Firmware issue?
> >
> > IIUC BIOS creates the CEDT based on the hardware it 'sees' as present.
> >
> > This patch is describing the case (weird as it seems to me) where we
> > then boot a system with ACPI and NUMA enabled but CXL_ACPI disabled.
> >
> > So, I don't think we can blame BIOS.
> >
> > >
> > > Is GNR exporting more CFMWS than it should?
> > Not sure of any limits on flavors of CFMWS's a BIOS can offer.
> > If BIOS can carve out a window, it can create a CFMWS.
> > Not clear how that matters to the issue.
> >
> > >
> > > Is your SRAT missing entries for CFMWS that are otherwise present?
> > >
> > > Are the CFMWS empty? (is that even valid)
> >
> > Why this line of questioning ;) I see the problem as a bit simpler.
> > We have other code that tells us if the CFMWS's are valid, etc, but
> > the point here is, we are not going to use these CFMWS's so stop
> > the parse as early as possible, like right here as Kai has done.
> >
>
> Mostly i'm wondering if this issue should be dealt with in the acpi code
> or if the issue is that we just don't want to figure out how to
> lazy-create these things instead of always creating them at __init.
>
> it does seem rational to build out support for CEDT entries if CXL_ACPI
> is built out, but this also means you can't otherwise load modules that
> would have made use of this information.
Besides CXL_ACPI, is there any other module(s) that uses this information
for these CXL memory regions?
>
> This basically says if specifically CXL_ACPI is built out, the NUMA
> structure is forever lost - even though it's accurately described by
> BIOS.
>
The normal NUMA info described in SRAT is still there. It only avoids
detecting CFMWS, which doesn't provide any NUMA info actually -- that's why
kernel assigns a 'faked' NUMA node for each of them.
So we are not losing anything AFAICT.
next prev parent reply other threads:[~2026-03-05 0:14 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-04 21:33 [PATCH] ACPI: NUMA: Only parse CFMWS at boot when CXL_ACPI is on Kai Huang
2026-03-04 22:33 ` Gregory Price
2026-03-04 23:20 ` Alison Schofield
2026-03-04 23:56 ` Gregory Price
2026-03-05 0:14 ` Huang, Kai [this message]
2026-03-05 0:29 ` Gregory Price
2026-03-05 0:45 ` Huang, Kai
2026-03-05 1:05 ` Gregory Price
2026-03-05 1:29 ` dan.j.williams
2026-03-05 1:51 ` Huang, Kai
2026-03-05 2:08 ` dan.j.williams
2026-03-05 2:22 ` Gregory Price
2026-03-05 3:01 ` dan.j.williams
2026-03-05 10:24 ` Huang, Kai
2026-03-05 8:11 ` Haifeng Xu
2026-03-05 10:25 ` Huang, Kai
2026-03-05 11:26 ` Haifeng Xu
2026-03-05 0:04 ` Huang, Kai
2026-03-05 0:44 ` Alison Schofield
2026-03-05 1:12 ` Huang, Kai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4809035f61dcd6ace773532efe46b0f1928be313.camel@intel.com \
--to=kai.huang@intel.com \
--cc=akpm@linux-foundation.org \
--cc=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=gourry@gourry.net \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nunodasneves@linux.microsoft.com \
--cc=rafael@kernel.org \
--cc=thorsten.blum@linux.dev \
--cc=wangyuquan1236@phytium.com.cn \
--cc=xueshuai@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox