From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "helgaas@kernel.org" <helgaas@kernel.org>
Cc: "rafael@kernel.org" <rafael@kernel.org>,
"linux-cxl@vger.kernel.org" <linux-cxl@vger.kernel.org>,
"Jonathan.Cameron@Huawei.com" <Jonathan.Cameron@Huawei.com>,
"Williams, Dan J" <dan.j.williams@intel.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
"Moore, Robert" <robert.moore@intel.com>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"dave@stgolabs.net" <dave@stgolabs.net>
Subject: Re: [PATCH v3 1/3] acpi: add a helper for retrieving _OSC Control DWORDs
Date: Wed, 30 Mar 2022 20:08:06 +0000 [thread overview]
Message-ID: <48dd8104149fe483d8b0b0e343b1e3c146eae339.camel@intel.com> (raw)
In-Reply-To: <20220330190443.GA1700287@bhelgaas>
On Wed, 2022-03-30 at 14:04 -0500, Bjorn Helgaas wrote:
> Look at previous subject lines and copy the style instead of making up
> something new.
Yep will fix.
>
> On Wed, Mar 30, 2022 at 12:14:32PM -0600, Vishal Verma wrote:
> > During _OSC negotiation, when the 'Control' DWORD is needed from the
> > result buffer after running _OSC, a couple of places performed manual
> > pointer arithmetic to offset into the right spot in the raw buffer.
> > Add a acpi_osc_ctx_get_pci_control() helper to use the #define'd
> > DWORD offsets to fetch the DWORDs needed from @acpi_osc_context, and
> > replace the above instances of the open-coded arithmetic.
>
> Bjorn
next prev parent reply other threads:[~2022-03-30 20:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 18:14 [PATCH v3 0/3] acpi: add support for CXL _OSC Vishal Verma
2022-03-30 18:14 ` [PATCH v3 1/3] acpi: add a helper for retrieving _OSC Control DWORDs Vishal Verma
2022-03-30 19:04 ` Bjorn Helgaas
2022-03-30 20:08 ` Verma, Vishal L [this message]
2022-03-30 18:14 ` [PATCH v3 2/3] PCI/ACPI: Use CXL _OSC instead of PCIe _OSC Vishal Verma
2022-03-30 18:14 ` [PATCH v3 3/3] acpi/pci_root: negotiate CXL _OSC Vishal Verma
2022-03-30 19:01 ` Bjorn Helgaas
2022-03-30 20:16 ` Verma, Vishal L
2022-03-30 20:30 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48dd8104149fe483d8b0b0e343b1e3c146eae339.camel@intel.com \
--to=vishal.l.verma@intel.com \
--cc=Jonathan.Cameron@Huawei.com \
--cc=bhelgaas@google.com \
--cc=dan.j.williams@intel.com \
--cc=dave@stgolabs.net \
--cc=helgaas@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-cxl@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox